CLOUDSTACK-9725 Failed to update VPC Network during N/w offering Upgr…

[bvbharatk]

…ade which doesnt have ACL service Enabled.

check if acl service provider is configured when network is associated with a acl.

[jayapalu]

Code LGTM

[ustcweizhou]

LGTM

[bvbharatk]

Ready to merge.

[rohityadavcloud]

@blueorangutan package
LGTM (code review only) /cc @karuturi

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-665

[rohityadavcloud]

@blueorangutan test centos7 vmware-55u3

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-55u3) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-1027)
Environment: vmware-55u3 (x2), Advanced Networking with Mgmt server 7
Total time taken: 53761 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr1970-t1027-vmware-55u3.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_deploy_vms_with_varied_deploymentplanners.py
Intermitten failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Intermitten failure detected: /marvin/tests/smoke/test_routers.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_vpn.py
Test completed. 46 look ok, 5 have error(s)

Test	Result	Time (s)	Test File
test_04_rvpc_privategw_static_routes	Failure	332.89	test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup	Failure	111.59	test_privategw_acl.py
test_02_vpc_privategw_static_routes	Failure	192.19	test_privategw_acl.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces	Failure	454.30	test_internal_lb.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup	Error	0.00	test_vpc_vpn.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup	Error	0.00	test_vpc_vpn.py
test_04_rvpc_network_garbage_collector_nics	Error	141.79	test_vpc_redundant.py
test_06_verify_guest_lspci_again	Error	0.00	test_deploy_virtio_scsi_vm.py
test_05_change_vm_ostype_restart	Error	0.00	test_deploy_virtio_scsi_vm.py
test_04_verify_guest_lspci	Error	0.00	test_deploy_virtio_scsi_vm.py
test_03_verify_libvirt_attach_disk	Error	0.00	test_deploy_virtio_scsi_vm.py
test_02_verify_libvirt_after_restart	Error	0.00	test_deploy_virtio_scsi_vm.py
test_01_verify_libvirt	Error	0.00	test_deploy_virtio_scsi_vm.py
ContextSuite context=TestDeployVirtioSCSIVM>:teardown	Error	0.00	test_deploy_virtio_scsi_vm.py
test_01_vpc_site2site_vpn	Success	381.63	test_vpc_vpn.py
test_02_VPC_default_routes	Success	363.33	test_vpc_router_nics.py
test_01_VPC_nics_after_destroy	Success	832.33	test_vpc_router_nics.py
test_05_rvpc_multi_tiers	Success	657.16	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	Success	750.74	test_vpc_redundant.py
test_02_redundant_VPC_default_routes	Success	630.14	test_vpc_redundant.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL	Success	1382.13	test_vpc_redundant.py
test_09_delete_detached_volume	Success	26.00	test_volumes.py
test_06_download_detached_volume	Success	95.75	test_volumes.py
test_05_detach_volume	Success	110.37	test_volumes.py
test_04_delete_attached_volume	Success	10.21	test_volumes.py
test_03_download_attached_volume	Success	15.29	test_volumes.py
test_02_attach_volume	Success	53.79	test_volumes.py
test_01_create_volume	Success	443.12	test_volumes.py
test_change_service_offering_for_vm_with_snapshots	Success	587.95	test_vm_snapshots.py
test_03_delete_vm_snapshots	Success	275.18	test_vm_snapshots.py
test_02_revert_vm_snapshots	Success	199.19	test_vm_snapshots.py
test_01_create_vm_snapshots	Success	129.39	test_vm_snapshots.py
test_deploy_vm_multiple	Success	212.46	test_vm_life_cycle.py
test_deploy_vm	Success	0.03	test_vm_life_cycle.py
test_advZoneVirtualRouter	Success	0.02	test_vm_life_cycle.py
test_10_attachAndDetach_iso	Success	26.86	test_vm_life_cycle.py
test_09_expunge_vm	Success	125.35	test_vm_life_cycle.py
test_08_migrate_vm	Success	126.46	test_vm_life_cycle.py
test_07_restore_vm	Success	0.11	test_vm_life_cycle.py
test_06_destroy_vm	Success	10.15	test_vm_life_cycle.py
test_03_reboot_vm	Success	5.16	test_vm_life_cycle.py
test_02_start_vm	Success	20.25	test_vm_life_cycle.py
test_01_stop_vm	Success	5.12	test_vm_life_cycle.py
test_CreateTemplateWithDuplicateName	Success	437.86	test_templates.py
test_08_list_system_templates	Success	0.03	test_templates.py
test_07_list_public_templates	Success	0.04	test_templates.py
test_05_template_permissions	Success	0.06	test_templates.py
test_04_extract_template	Success	15.22	test_templates.py
test_03_delete_template	Success	5.11	test_templates.py
test_02_edit_template	Success	90.16	test_templates.py
test_01_create_template	Success	211.41	test_templates.py
test_10_destroy_cpvm	Success	266.97	test_ssvm.py
test_09_destroy_ssvm	Success	238.72	test_ssvm.py
test_08_reboot_cpvm	Success	156.61	test_ssvm.py
test_07_reboot_ssvm	Success	188.73	test_ssvm.py
test_06_stop_cpvm	Success	206.88	test_ssvm.py
test_05_stop_ssvm	Success	204.16	test_ssvm.py
test_04_cpvm_internals	Success	1.16	test_ssvm.py
test_03_ssvm_internals	Success	3.66	test_ssvm.py
test_02_list_cpvm_vm	Success	0.14	test_ssvm.py
test_01_list_sec_storage_vm	Success	0.14	test_ssvm.py
test_02_list_snapshots_with_removed_data_store	Success	233.05	test_snapshots.py
test_01_snapshot_root_disk	Success	66.51	test_snapshots.py
test_04_change_offering_small	Success	96.86	test_service_offerings.py
test_03_delete_service_offering	Success	0.07	test_service_offerings.py
test_02_edit_service_offering	Success	0.09	test_service_offerings.py
test_01_create_service_offering	Success	0.11	test_service_offerings.py
test_02_sys_template_ready	Success	0.16	test_secondary_storage.py
test_01_sys_vm_start	Success	0.19	test_secondary_storage.py
test_09_reboot_router	Success	166.11	test_routers.py
test_08_start_router	Success	156.03	test_routers.py
test_07_stop_router	Success	25.27	test_routers.py
test_06_router_advanced	Success	0.07	test_routers.py
test_05_router_basic	Success	0.06	test_routers.py
test_04_restart_network_wo_cleanup	Success	5.68	test_routers.py
test_03_restart_network_cleanup	Success	161.12	test_routers.py
test_02_router_internal_adv	Success	1.09	test_routers.py
test_01_router_internal_basic	Success	0.59	test_routers.py
test_router_dns_guestipquery	Success	76.76	test_router_dns.py
test_router_dns_externalipquery	Success	0.07	test_router_dns.py
test_router_dhcphosts	Success	151.23	test_router_dhcphosts.py
test_router_dhcp_opts	Success	21.74	test_router_dhcphosts.py
test_01_updatevolumedetail	Success	0.08	test_resource_detail.py
test_01_reset_vm_on_reboot	Success	35.41	test_reset_vm_on_reboot.py
test_createRegion	Success	0.04	test_regions.py
test_create_pvlan_network	Success	5.23	test_pvlan.py
test_dedicatePublicIpRange	Success	0.45	test_public_ip_range.py
test_01_vpc_privategw_acl	Success	178.01	test_privategw_acl.py
test_03_migration_options_storage_tags	Success	37.56	test_primary_storage.py
test_02_edit_primary_storage_tags	Success	0.12	test_primary_storage.py
test_01_primary_storage_nfs	Success	37.33	test_primary_storage.py
test_01_deploy_vms_storage_tags	Success	41.56	test_primary_storage.py
test_createPortablePublicIPRange	Success	15.20	test_portable_publicip.py
test_createPortablePublicIPAcquire	Success	15.46	test_portable_publicip.py
test_isolate_network_password_server	Success	59.20	test_password_server.py
test_UpdateStorageOverProvisioningFactor	Success	0.15	test_over_provisioning.py
test_oobm_zchange_password	Success	30.89	test_outofbandmanagement.py
test_oobm_multiple_mgmt_server_ownership	Success	16.36	test_outofbandmanagement.py
test_oobm_issue_power_status	Success	10.26	test_outofbandmanagement.py
test_oobm_issue_power_soft	Success	15.38	test_outofbandmanagement.py
test_oobm_issue_power_reset	Success	15.50	test_outofbandmanagement.py
test_oobm_issue_power_on	Success	15.41	test_outofbandmanagement.py
test_oobm_issue_power_off	Success	15.35	test_outofbandmanagement.py
test_oobm_issue_power_cycle	Success	15.35	test_outofbandmanagement.py
test_oobm_enabledisable_across_clusterzones	Success	87.95	test_outofbandmanagement.py
test_oobm_enable_feature_valid	Success	5.26	test_outofbandmanagement.py
test_oobm_enable_feature_invalid	Success	0.13	test_outofbandmanagement.py
test_oobm_disable_feature_valid	Success	5.24	test_outofbandmanagement.py
test_oobm_disable_feature_invalid	Success	0.14	test_outofbandmanagement.py
test_oobm_configure_invalid_driver	Success	0.09	test_outofbandmanagement.py
test_oobm_configure_default_driver	Success	0.09	test_outofbandmanagement.py
test_oobm_background_powerstate_sync	Success	23.50	test_outofbandmanagement.py
test_extendPhysicalNetworkVlan	Success	15.34	test_non_contigiousvlan.py
test_01_nic	Success	581.22	test_nic.py
test_releaseIP	Success	227.90	test_network.py
test_reboot_router	Success	806.59	test_network.py
test_public_ip_user_account	Success	10.28	test_network.py
test_public_ip_admin_account	Success	40.32	test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule	Success	76.84	test_network.py
test_network_rules_acquired_public_ip_2_nat_rule	Success	61.73	test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule	Success	124.83	test_network.py
test_delete_account	Success	283.09	test_network.py
test_02_port_fwd_on_non_src_nat	Success	55.81	test_network.py
test_01_port_fwd_on_src_nat	Success	111.96	test_network.py
test_nested_virtualization_vmware	Success	398.87	test_nested_virtualization.py
test_nic_secondaryip_add_remove	Success	258.11	test_multipleips_per_nic.py
test_list_zones_metrics	Success	0.28	test_metrics_api.py
test_list_volumes_metrics	Success	5.51	test_metrics_api.py
test_list_vms_metrics	Success	206.93	test_metrics_api.py
test_list_pstorage_metrics	Success	0.34	test_metrics_api.py
test_list_infrastructure_metrics	Success	0.52	test_metrics_api.py
test_list_hosts_metrics	Success	0.44	test_metrics_api.py
test_list_clusters_metrics	Success	0.38	test_metrics_api.py
login_test_saml_user	Success	19.45	test_login.py
test_assign_and_removal_lb	Success	148.78	test_loadbalance.py
test_02_create_lb_rule_non_nat	Success	207.71	test_loadbalance.py
test_01_create_lb_rule_src_nat	Success	208.10	test_loadbalance.py
test_03_list_snapshots	Success	0.09	test_list_ids_parameter.py
test_02_list_templates	Success	0.04	test_list_ids_parameter.py
test_01_list_volumes	Success	0.03	test_list_ids_parameter.py
test_07_list_default_iso	Success	0.07	test_iso.py
test_05_iso_permissions	Success	0.07	test_iso.py
test_04_extract_Iso	Success	5.21	test_iso.py
test_03_delete_iso	Success	95.29	test_iso.py
test_02_edit_iso	Success	0.10	test_iso.py
test_01_create_iso	Success	21.07	test_iso.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces	Success	369.24	test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80	Success	1065.64	test_internal_lb.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80	Success	832.50	test_internal_lb.py
test_dedicateGuestVlanRange	Success	10.31	test_guest_vlan_range.py
test_UpdateConfigParamWithScope	Success	0.15	test_global_settings.py
test_rolepermission_lifecycle_update	Success	6.35	test_dynamicroles.py
test_rolepermission_lifecycle_list	Success	6.08	test_dynamicroles.py
test_rolepermission_lifecycle_delete	Success	5.89	test_dynamicroles.py
test_rolepermission_lifecycle_create	Success	6.01	test_dynamicroles.py
test_rolepermission_lifecycle_concurrent_updates	Success	6.05	test_dynamicroles.py
test_role_lifecycle_update_role_inuse	Success	5.92	test_dynamicroles.py
test_role_lifecycle_update	Success	6.01	test_dynamicroles.py
test_role_lifecycle_list	Success	5.98	test_dynamicroles.py
test_role_lifecycle_delete	Success	10.97	test_dynamicroles.py
test_role_lifecycle_create	Success	5.93	test_dynamicroles.py
test_role_inuse_deletion	Success	5.90	test_dynamicroles.py
test_role_account_acls_multiple_mgmt_servers	Success	8.24	test_dynamicroles.py
test_role_account_acls	Success	9.17	test_dynamicroles.py
test_default_role_deletion	Success	6.04	test_dynamicroles.py
test_04_create_fat_type_disk_offering	Success	0.10	test_disk_offerings.py
test_03_delete_disk_offering	Success	0.04	test_disk_offerings.py
test_02_edit_disk_offering	Success	0.05	test_disk_offerings.py
test_02_create_sparse_type_disk_offering	Success	0.08	test_disk_offerings.py
test_01_create_disk_offering	Success	0.12	test_disk_offerings.py
test_deployvm_userdispersing	Success	60.96	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userconcentrated	Success	65.91	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_firstfit	Success	161.43	test_deploy_vms_with_varied_deploymentplanners.py
test_deployvm_userdata_post	Success	85.92	test_deploy_vm_with_userdata.py
test_deployvm_userdata	Success	211.82	test_deploy_vm_with_userdata.py
test_02_deploy_vm_root_resize	Success	5.93	test_deploy_vm_root_resize.py
test_01_deploy_vm_root_resize	Success	5.87	test_deploy_vm_root_resize.py
test_00_deploy_vm_root_resize	Success	6.00	test_deploy_vm_root_resize.py
test_deploy_vm_from_iso	Success	252.82	test_deploy_vm_iso.py
test_3d_gpu_support	Success	641.41	test_deploy_vgpu_enabled_vm.py
test_DeployVmAntiAffinityGroup	Success	337.83	test_affinity_groups.py
test_08_resize_volume	Skipped	5.12	test_volumes.py
test_07_resize_fail	Skipped	10.29	test_volumes.py
test_06_copy_template	Skipped	0.00	test_templates.py
test_static_role_account_acls	Skipped	0.02	test_staticroles.py
test_11_ss_nfs_version_on_ssvm	Skipped	0.02	test_ssvm.py
test_01_scale_vm	Skipped	66.40	test_scale_vm.py
test_01_primary_storage_iscsi	Skipped	0.04	test_primary_storage.py
test_06_copy_iso	Skipped	0.00	test_iso.py
test_deploy_vgpu_enabled_vm	Skipped	1.09	test_deploy_vgpu_enabled_vm.py

[karuturi]

test failures. please check the cause.

[karuturi]

failures are high.
@rhtyd @borisstoyanov Can you check if its environment issue? I think I have seen the same failures atleast on 3 PRs.

[borisstoyanov]

@karuturi These errors are due to this: #2066

[karuturi]

ok. thanks @borisstoyanov will merge #2066 as soon as the tests results are ready.