Fix for test_snapshots.py using nfs2 instead of nfs template #1961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@blueorangutan package |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
Contributor
|
Thanks for this fix @nvazquez, I'll kick marvin tests to verify it doesn't brake any other test. |
Contributor
Author
|
@borisstoyanov great, thanks! |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-531 |
Contributor
|
@blueorangutan test |
|
@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
LGTM |
|
Trillian test result (tid-890)
|
Member
|
@nvazquez Are you looking at the test failures? |
Contributor
Author
|
@karuturi @borisstoyanov next step will be updating Marvin's folder |
Member
|
@serg38 okay, we can add this to test_data /cc @PaulAngus |
borisstoyanov
pushed a commit
to shapeblue/Trillian
that referenced
this pull request
Feb 27, 2017
…pass newly introduced test in apache/cloudstack#1961
nvazquez
force-pushed
the
addNewNfsTestData
branch
from
e0c2ad8 to
7000144
Compare
Contributor
Author
|
Hi @karuturi @rhtyd @borisstoyanov, These were results in our env, using Vmware: |
Contributor
|
thanks @nvazquez let me package again |
|
@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-553 |
Contributor
|
@nvazquez I'm getting the following error: does the test detach the volume from VM before migrating it? didn't managed to find that part looking in the code. |
| ) | ||
| assert isinstance(clusters,list) and len(clusters)>0 | ||
|
|
||
| storage = StoragePool.create(self.apiclient, |
Contributor
There was a problem hiding this comment.
I think It's good append this storage to cleanup as soon as it's created. I've hit the exact issue that would leave it added in Cloudstack. I've a test failure before the point it is appended and cleanup() didn't wiped it.
Contributor
Author
There was a problem hiding this comment.
Done, thanks for pointing it out!
nvazquez
force-pushed
the
addNewNfsTestData
branch
from
7000144 to
c3d18b2
Compare
Contributor
Author
|
@borisstoyanov actually disk is not being dettached from vm before migrating it, it is using vm's ROOT disk, it can be done on Vmware by setting |
nvazquez
force-pushed
the
addNewNfsTestData
branch
from
c3d18b2 to
c66df6e
Compare
Contributor
Author
|
@borisstoyanov I refactored marvin test to migrate a detached disk instead of vm's root volume as it was before. Can you please test it again in your env? |
Member
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔centos6 ✔centos7 ✔debian. JID-559 |
Member
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-926)
|
|
@rhtyd @borisstoyanov did you have a chance to add nfs2 test data in B.O. ? |
Contributor
|
Yes @serg38, but currently testing it. So this batch doesn't have it. |
Contributor
borisstoyanov
approved these changes
Mar 6, 2017
Contributor
borisstoyanov
left a comment
borisstoyanov
left a comment
There was a problem hiding this comment.
Tests has passed
[root@ref-trl-99-k-cs410-bstoyanov-marvin ~]# cat /marvin//MarvinLogs/test_snapshots_76YGPX/results.txt
Test Snapshot Root Disk ... === TestName: test_01_snapshot_root_disk | Status : SUCCESS ===
ok
Test listing volume snapshots with removed data stores ... === TestName: test_02_list_snapshots_with_removed_data_store | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 216.488s
OK
Contributor
Author
|
That's great! Thanks @borisstoyanov for your help! |
|
LGTM |
DagSonsteboSB
pushed a commit
to shapeblue/Trillian
that referenced
this pull request
Mar 9, 2017
#18) Adding a nfs2 hardcoded entry in Trillian's test_data.py in order to pass newly introduced test in apache/cloudstack#1961 Added marvin shares to nested group vars. Updated addshares to handle marvin primary shares.
asfgit
pushed a commit
that referenced
this pull request
Mar 28, 2017
Fix for test_snapshots.py using nfs2 instead of nfs templateFix for marvin test failure introduced in #1847 Cc: @borisstoyanov @rhtyd @karuturi * pr/1961: Fix for test failure Fix for test_snapshots.py using nfs2 instead of nfs template Signed-off-by: Rajani Karuturi <[email protected]>
Member
|
This needed to be merged on 4.9 as well since #1847 was merged on 4.9+ as well, this has now caused regressions in 4.9 branch. I'll have to backport the fixes on 4.9 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for marvin test failure introduced in #1847
Cc: @borisstoyanov @rhtyd @karuturi