Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
167 commits
Select commit Hold shift + click to select a range
e5f499a
Rules and visitors for Load Balance Rules
Jul 3, 2014
ea98c51
Adding new behaviour to the apply load balancing rules method. The wh…
wilderrodrigues Jul 4, 2014
c3b35da
Extract general behavior to Router and Vpc delegates
Jul 10, 2014
7a7aaf7
Fix dependency problem. Extract and unify router deployment stuff
Jul 11, 2014
e64664f
Adding Firewall Rules to comply with the Visitor pattern implementati…
Jul 13, 2014
cb8b565
changing accessor modifier in instance variables
Jul 14, 2014
a9d751c
fixing checkstyles
wilderrodrigues Jul 14, 2014
22d4171
finished firewall rules and load balancing rules; fixed all the injec…
wilderrodrigues Jul 14, 2014
8f9b7de
TODO
DaanHoogland Jul 14, 2014
ee70079
adding static nat rules. Deploying new VMs is not working due to the …
wilderrodrigues Jul 14, 2014
25d11bc
we have to check if VPC is null bfore calling it. VPC is not used in …
wilderrodrigues Jul 15, 2014
9983ae3
adding apache license headers
wilderrodrigues Jul 15, 2014
4c7b700
adding Ip Association and VPN Rules
wilderrodrigues Jul 15, 2014
975cec4
Fix offering setup
Jul 15, 2014
f6e3e43
package rename
DaanHoogland Jul 15, 2014
82c8d6b
Temporary put state info in a state object
Jul 15, 2014
be8e1de
fixing the classes relationship; adding beans properly in the spring …
wilderrodrigues Jul 15, 2014
5ee648c
adding password to router rules; moving the advance code to the advan…
wilderrodrigues Jul 15, 2014
1c945cb
Unify and encapsulate deployment flow methods and params
Jul 15, 2014
485c7d3
adding userdata to router and ssh pub key to router rules.
wilderrodrigues Jul 16, 2014
e191bab
making instance variables compliant with ACS convention
wilderrodrigues Jul 16, 2014
0321f36
adding user data pwd rules
wilderrodrigues Jul 16, 2014
46ac576
adding DHCP entry rules
wilderrodrigues Jul 16, 2014
7759232
fixing injection of beans with a relationship
wilderrodrigues Jul 16, 2014
3df2290
whitespace
DaanHoogland Jul 16, 2014
15b4f30
fixing the injection of the networkDao
wilderrodrigues Jul 16, 2014
e9b1b04
mv to better name
DaanHoogland Jul 16, 2014
8af47e4
Deployment more OO - Objects with data and behavior
Jul 16, 2014
6a0008b
replacing my IP by localhost to avoid problems with my environment
wilderrodrigues Jul 17, 2014
a734272
fixing import in virtual router element and checkstyle in dhcp entry …
wilderrodrigues Jul 17, 2014
2e54654
commenting broken code in tests in order to run build adn tests other…
wilderrodrigues Jul 17, 2014
93c9ad6
removing bean from the xml
wilderrodrigues Jul 17, 2014
f79bd2e
adding new bean to spring context file; renaming package from "com" t…
wilderrodrigues Jul 17, 2014
036f9bf
Missing dependencies are added
Jul 17, 2014
5b5ada1
Fixing null pointers during vpc router deployment
Jul 17, 2014
b67a983
apply network acls; acls items to pvt gw; vpc ip association
wilderrodrigues Jul 17, 2014
2ebec42
fixing VPC IP Association and ACL rules. Have to rewrite in a better …
wilderrodrigues Jul 18, 2014
ee72d57
Splitting Vpc and NonVpc deployment into phases & testing it
Jul 17, 2014
3b772b7
RouterDeployment and VPC. Improving code and Unit Testing
Jul 23, 2014
279a1ea
rename networkMgr to networkMdl to prevent name clashes in mocks of
DaanHoogland Jul 23, 2014
09155a1
More refactoring and testing in the same classes
Jul 27, 2014
3be18b9
License headers
Jul 28, 2014
7374385
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
wilderrodrigues Aug 18, 2014
b1e3c47
Complete tests for normal deployment and start vpc one
Jul 28, 2014
5315fd6
Factor out prepareDeployment and update tests
Jul 29, 2014
dfc951a
Increasing test coverage for Vpc Deployment
Jul 29, 2014
bdfb824
Fix unnecessary changes Spring contexts
Aug 18, 2014
210c0e7
Adding VpcRouterDeploymentDefinition Unit Tests
Aug 18, 2014
05b9f3b
moving sendCommand to the NetworkGeneralHelper;
wilderrodrigues Aug 19, 2014
2d864f0
fixing check styles
wilderrodrigues Aug 19, 2014
ea05de8
Refactor to include network creation as actual deployment
Aug 19, 2014
283111e
adding applyStaticRoutes method to the network topology/visitor. it w…
wilderrodrigues Aug 19, 2014
6ef7258
adding applyStaticRoutes to the new visitor pattern.
wilderrodrigues Aug 19, 2014
5030659
refactor VpnRules onto BasicVpnRules and AdvancedVpnRules;
wilderrodrigues Aug 19, 2014
4eb9a5d
DeployRouter includes nw creation following TellDontAsk principle
Aug 20, 2014
179cb56
Whole router.deployment package got 97% coverage
Aug 20, 2014
b821996
adding setupPrivateGateway to new style;
wilderrodrigues Aug 20, 2014
187b73f
fixing the private gateway rules in order to comply with changes in t…
wilderrodrigues Aug 21, 2014
a0cd795
fixing check style issues
wilderrodrigues Aug 21, 2014
c07bf9d
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers
Aug 21, 2014
b297e69
Missing license headers
Aug 21, 2014
9482db3
refactor all private methods in the virtual router appliance and VPC …
wilderrodrigues Aug 21, 2014
c817086
Fix Spring collision of beans implementing NetworkHelper
Aug 21, 2014
0b6408c
auto wire the network helper
wilderrodrigues Aug 21, 2014
f93a0e0
Refactor hypervisor retrieval from VpcNwHelper and NwHelper
Aug 21, 2014
79b14eb
Fixing NPE due to use of dependencies before Spring injection
Aug 22, 2014
40e5e91
fix dhcp subnet rules. we can create VMs again.
wilderrodrigues Aug 23, 2014
2c80f2e
fixing nic plug unplug rule
wilderrodrigues Aug 25, 2014
da811d3
merging cmd-visitor into cmd-visitor-rebase, with the upstream from A…
wilderrodrigues Sep 5, 2014
bee9016
merging cmd-visitor into cmd-visitor-rebase, with the upstream from A…
wilderrodrigues Sep 5, 2014
a951c38
Fix: VpcRouter has always PublicIp setup as it did before refactoring
Aug 28, 2014
9cafba0
making sure the instance variable _router in the Rules is being used …
wilderrodrigues Sep 2, 2014
83e55fe
removing the root password becuase it was breaking the simulator test…
wilderrodrigues Sep 2, 2014
4206da2
Removing the VirtualNetworkStatus, it was not being used properly;
wilderrodrigues Sep 4, 2014
87ba46f
Adding fixes for the add user data and vpn rules
wilderrodrigues Sep 8, 2014
58a4dab
Changing the way the DAOs were being injected in the RuleApplier;
wilderrodrigues Sep 9, 2014
6a6b5ea
fixing checkstyle in the virtual network manager. problem appeared af…
wilderrodrigues Sep 9, 2014
63ea596
removed unused class
Sep 10, 2014
4c9507d
CLOUDSTACK-6898: [Hyper-V] fixed rdp console freezing during reboot.
anshulgangwar Sep 3, 2014
a400eec
CLOUDSTACK-7503: Fixed few coverity issues
anshulgangwar Sep 4, 2014
b4f03a1
CLOUDSTACK-7517: loading ftp modules in VR
Sep 10, 2014
81d5dd9
CLOUDSTACK-7519: Using bound/unbound methods instead of directly call…
Sep 9, 2014
91fd8d7
CLOUDSTACK-7528: More verbose logging when sending alert fails
rohityadavcloud Sep 10, 2014
75cd79a
CLOUDSTACK-7520: [UI] keep advanced search parameters visible after s…
Sep 9, 2014
70142c4
Added "usageid" parameter to the "listUsageRecords" API call. Can be …
Sep 9, 2014
2b7b837
CLOUDSTACK-6099 live migration is failing for vm deployed using dynai…
bvbharat Sep 8, 2014
8929d74
SAML2UserAuthenticatorTest: Fix test, make sure encoded password leng…
rohityadavcloud Sep 10, 2014
3411fba
CLOUDSTACK-7351: Passing hypervisor type while deploying VM using ISO
Sep 10, 2014
a59da9b
Rules and visitors for Load Balance Rules
Jul 3, 2014
5015077
Adding new behaviour to the apply load balancing rules method. The wh…
wilderrodrigues Jul 4, 2014
fa8ec84
Extract general behavior to Router and Vpc delegates
Jul 10, 2014
905ebf0
Fix dependency problem. Extract and unify router deployment stuff
Jul 11, 2014
8ca73cb
Adding Firewall Rules to comply with the Visitor pattern implementati…
Jul 13, 2014
3a20b32
changing accessor modifier in instance variables
Jul 14, 2014
caa8072
fixing checkstyles
wilderrodrigues Jul 14, 2014
9ca8a39
finished firewall rules and load balancing rules; fixed all the injec…
wilderrodrigues Jul 14, 2014
6ca9a09
TODO
DaanHoogland Jul 14, 2014
d0a6225
adding static nat rules. Deploying new VMs is not working due to the …
wilderrodrigues Jul 14, 2014
4ed9667
we have to check if VPC is null bfore calling it. VPC is not used in …
wilderrodrigues Jul 15, 2014
cf5d961
adding apache license headers
wilderrodrigues Jul 15, 2014
d99e630
adding Ip Association and VPN Rules
wilderrodrigues Jul 15, 2014
43981a2
Fix offering setup
Jul 15, 2014
590cf4e
package rename
DaanHoogland Jul 15, 2014
55bedbd
Temporary put state info in a state object
Jul 15, 2014
05612b4
fixing the classes relationship; adding beans properly in the spring …
wilderrodrigues Jul 15, 2014
3b3a1f3
adding password to router rules; moving the advance code to the advan…
wilderrodrigues Jul 15, 2014
ffa85ef
Unify and encapsulate deployment flow methods and params
Jul 15, 2014
57d0053
adding userdata to router and ssh pub key to router rules.
wilderrodrigues Jul 16, 2014
5887051
making instance variables compliant with ACS convention
wilderrodrigues Jul 16, 2014
6208a88
adding user data pwd rules
wilderrodrigues Jul 16, 2014
0f9552f
adding DHCP entry rules
wilderrodrigues Jul 16, 2014
246027c
fixing injection of beans with a relationship
wilderrodrigues Jul 16, 2014
babb746
whitespace
DaanHoogland Jul 16, 2014
1952cce
fixing the injection of the networkDao
wilderrodrigues Jul 16, 2014
a1cde72
mv to better name
DaanHoogland Jul 16, 2014
39c0129
Deployment more OO - Objects with data and behavior
Jul 16, 2014
ebf211e
replacing my IP by localhost to avoid problems with my environment
wilderrodrigues Jul 17, 2014
983c826
fixing import in virtual router element and checkstyle in dhcp entry …
wilderrodrigues Jul 17, 2014
8a57424
commenting broken code in tests in order to run build adn tests other…
wilderrodrigues Jul 17, 2014
03bf0be
removing bean from the xml
wilderrodrigues Jul 17, 2014
dca2233
adding new bean to spring context file; renaming package from "com" t…
wilderrodrigues Jul 17, 2014
cf6dfb6
Missing dependencies are added
Jul 17, 2014
507af7b
Fixing null pointers during vpc router deployment
Jul 17, 2014
5b30484
apply network acls; acls items to pvt gw; vpc ip association
wilderrodrigues Jul 17, 2014
712409a
fixing VPC IP Association and ACL rules. Have to rewrite in a better …
wilderrodrigues Jul 18, 2014
df315b6
Splitting Vpc and NonVpc deployment into phases & testing it
Jul 17, 2014
8066fec
RouterDeployment and VPC. Improving code and Unit Testing
Jul 23, 2014
87fe9d0
rename networkMgr to networkMdl to prevent name clashes in mocks of
DaanHoogland Jul 23, 2014
17b10a9
More refactoring and testing in the same classes
Jul 27, 2014
b236686
License headers
Jul 28, 2014
94980ea
Replacing the old [Vpc}VirtualNetworkApplianceManager by the new ones;
wilderrodrigues Aug 18, 2014
a60e7a0
Complete tests for normal deployment and start vpc one
Jul 28, 2014
e94fee3
Factor out prepareDeployment and update tests
Jul 29, 2014
6ada376
Increasing test coverage for Vpc Deployment
Jul 29, 2014
19308d7
Fix unnecessary changes Spring contexts
Aug 18, 2014
aed6088
Adding VpcRouterDeploymentDefinition Unit Tests
Aug 18, 2014
3c9de16
moving sendCommand to the NetworkGeneralHelper;
wilderrodrigues Aug 19, 2014
2a58382
fixing check styles
wilderrodrigues Aug 19, 2014
f64018f
Refactor to include network creation as actual deployment
Aug 19, 2014
f608e3d
adding applyStaticRoutes method to the network topology/visitor. it w…
wilderrodrigues Aug 19, 2014
05009af
adding applyStaticRoutes to the new visitor pattern.
wilderrodrigues Aug 19, 2014
21d8ef8
refactor VpnRules onto BasicVpnRules and AdvancedVpnRules;
wilderrodrigues Aug 19, 2014
167fac5
DeployRouter includes nw creation following TellDontAsk principle
Aug 20, 2014
2dbaa73
Whole router.deployment package got 97% coverage
Aug 20, 2014
308ceba
adding setupPrivateGateway to new style;
wilderrodrigues Aug 20, 2014
73d716c
fixing the private gateway rules in order to comply with changes in t…
wilderrodrigues Aug 21, 2014
a6b578a
fixing check style issues
wilderrodrigues Aug 21, 2014
61869de
Refactor and test NetworkHelper#sendCommandsToRouterWithNoAnswers
Aug 21, 2014
47ac5e7
Missing license headers
Aug 21, 2014
70c00c7
refactor all private methods in the virtual router appliance and VPC …
wilderrodrigues Aug 21, 2014
3591119
Fix Spring collision of beans implementing NetworkHelper
Aug 21, 2014
69ec8a1
auto wire the network helper
wilderrodrigues Aug 21, 2014
fe07107
Refactor hypervisor retrieval from VpcNwHelper and NwHelper
Aug 21, 2014
8a21526
Fixing NPE due to use of dependencies before Spring injection
Aug 22, 2014
be6c23f
fix dhcp subnet rules. we can create VMs again.
wilderrodrigues Aug 23, 2014
da93d8c
fixing nic plug unplug rule
wilderrodrigues Aug 25, 2014
e53a3fe
merging cmd-visitor into cmd-visitor-rebase, with the upstream from A…
wilderrodrigues Sep 5, 2014
ac98f91
merging cmd-visitor into cmd-visitor-rebase, with the upstream from A…
wilderrodrigues Sep 5, 2014
480f3e9
Fix: VpcRouter has always PublicIp setup as it did before refactoring
Aug 28, 2014
a82bf8b
making sure the instance variable _router in the Rules is being used …
wilderrodrigues Sep 2, 2014
6900ec4
removing the root password becuase it was breaking the simulator test…
wilderrodrigues Sep 2, 2014
d6e6e11
Removing the VirtualNetworkStatus, it was not being used properly;
wilderrodrigues Sep 4, 2014
e087b2a
Adding fixes for the add user data and vpn rules
wilderrodrigues Sep 8, 2014
20a65a1
Changing the way the DAOs were being injected in the RuleApplier;
wilderrodrigues Sep 9, 2014
6caa966
fixing checkstyle in the virtual network manager. problem appeared af…
wilderrodrigues Sep 9, 2014
ac15ec4
After an attempt to do a git pull --rebase followed by a push, I got …
wilderrodrigues Sep 10, 2014
8c0cb09
Fixing the NetworkHelperImpl class. It was throwing a NPE due to a hy…
wilderrodrigues Sep 11, 2014
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions api/src/org/apache/cloudstack/api/ApiConstants.java
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ public class ApiConstants {
public static final String VIRTUAL_MACHINE_ID = "virtualmachineid";
public static final String VIRTUAL_MACHINE_IDS = "virtualmachineids";
public static final String VIRTUAL_MACHINE_ID_IP = "vmidipmap";
public static final String USAGE_ID = "usageid";

public static final String VLAN = "vlan";
public static final String VLAN_RANGE = "vlanrange";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ public class GetUsageRecordsCmd extends BaseListCmd {
@Parameter(name = ApiConstants.TYPE, type = CommandType.LONG, description = "List usage records for the specified usage type")
private Long usageType;

@Parameter(name = ApiConstants.USAGE_ID, type = CommandType.STRING, description = "List usage records for the specified usage UUID. Can be used only together with TYPE parameter.")
private String usageId;

/////////////////////////////////////////////////////
/////////////////// Accessors ///////////////////////
/////////////////////////////////////////////////////
Expand Down Expand Up @@ -105,6 +108,10 @@ public Long getProjectId() {
return projectId;
}

public String getUsageId() {
return usageId;
}

/////////////////////////////////////////////////////
/////////////// API Implementation///////////////////
/////////////////////////////////////////////////////
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1843,7 +1843,7 @@ protected void migrate(VMInstanceVO vm, long srcHostId, DeployDestination dest)
vmSrc.addNic(nic);
}

VirtualMachineProfile profile = new VirtualMachineProfileImpl(vm);
VirtualMachineProfile profile = new VirtualMachineProfileImpl(vm, null, _offeringDao.findById(vm.getId(), vm.getServiceOfferingId()), null, null);
_networkMgr.prepareNicForMigration(profile, dest);
volumeMgr.prepareForMigration(profile, dest);

Expand Down
127 changes: 0 additions & 127 deletions engine/schema/src/com/cloud/upgrade/PremiumDatabaseUpgradeChecker.java

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -516,7 +516,7 @@ public final Answer executeRequest(final Command cmd) {
// Only Answer instances are returned by remote agents.
// E.g. see Response.getAnswers()
Answer[] result = s_gson.fromJson(ansStr, Answer[].class);
String logResult = cleanPassword(StringEscapeUtils.unescapeJava(result.toString()));
String logResult = cleanPassword(s_gson.toJson(result));
s_logger.debug("executeRequest received response " + logResult);
if (result.length > 0) {
return result[0];
Expand Down Expand Up @@ -547,7 +547,7 @@ private Answer execute(CopyCommand cmd) {
}

Answer[] result = s_gson.fromJson(ansStr, Answer[].class);
String logResult = cleanPassword(StringEscapeUtils.unescapeJava(result.toString()));
String logResult = cleanPassword(s_gson.toJson(result));
s_logger.debug("executeRequest received response " + logResult);
if (result.length > 0) {
return result[0];
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ under the License.
<checker name="ManagementServerNode" class="com.cloud.cluster.ManagementServerNode"/>
<checker name="EncryptionSecretKeyChecker" class="com.cloud.utils.crypt.EncryptionSecretKeyChecker"/>
<checker name="DatabaseIntegrityChecker" class="com.cloud.upgrade.DatabaseIntegrityChecker"/>
<checker name="DatabaseUpgradeChecker" class="com.cloud.upgrade.PremiumDatabaseUpgradeChecker"/>
</system-integrity-checker>

<interceptor library="com.cloud.configuration.DefaultInterceptorLibrary"/>
Expand Down
Loading