Skip to content

Conversation

@gauravaradhye
Copy link

  1. Reducing complexity of function "verifyVCenterPortGroups". Earlier it had two for loops, now it has only one. The parameter zone_list has been replaced with "zone" because we map a VCenter to a zone and not multiple zones.
  2. Correcting the logic used to generate expected port group names for public traffic. The port group with network rate as defined in "network.throttling.rate" is created only when a VM is deployed and its network uses a public IP from public IP range dedicated to public traffic.
  3. Adding a wrapper function for verifying guest traffic port groups which creates vcenter connection object and calls verifyVCenterPortGroups function with GUEST_TRAFFIC as parameter. This function is very handy and can be called from any networking test case with only a single line call. This separates the additional logic from test case and moves it to this wrapper function.

The code has been tested against multiple types of Vmware deployments including mixture tagged and untagged traffic types and mixed switches (SVS and DVS).

Gaurav Aradhye added 2 commits April 11, 2015 14:37
…nter port groups corresponding to traffic types in a zone
@srikanteswartalluri
Copy link
Contributor

This is merged. forgot to add 'This closes #155'
Gaurav,
Please close this PR.

@gauravaradhye gauravaradhye deleted the 8375 branch May 22, 2015 10:12
Pearl1594 pushed a commit to shapeblue/cloudstack that referenced this pull request Sep 6, 2022
* Extract the IO_URING configuration into the agent.properties (apache#6253)

When using advanced virtualization the IO Driver is not supported. The
admin will decide if want to enable/disable this configuration from
agent.properties file. The default value is true

* kvm: truncate vnc password to 8 chars (apache#6244)

This PR truncates the vnc password of kvm vms to 8 chars to support latest versions of libvirt.

* merge fix

Signed-off-by: Abhishek Kumar <[email protected]>

* [KVM] Enable IOURING only when it is available on the host (apache#6399)

* [KVM] Disable IOURING by default on agents

* Refactor

* Remove agent property for iouring

* Restore property

* Refactor suse check and enable on ubuntu by default

* Refactor irrespective of guest OS

* Improvement

* Logs and new path

* Refactor condition to enable iouring

* Improve condition

* Refactor property check

* Improvement

* Doc comment

* Extend comment

* Move method

* Add log

* [KVM] Fix VM migration error due to VNC password on libvirt limiting versions (apache#6404)

* [KVM] Fix VM migration error due to VNC password on libvirt limiting versions

* Fix passwd value

* Simplify implementation

Co-authored-by: slavkap <[email protected]>
Co-authored-by: Wei Zhou <[email protected]>
Co-authored-by: Nicolas Vazquez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants