Skip to content

Conversation

@shwstppr
Copy link
Contributor

Description

Instead listing all GIthub releases first and finding the latest one use the direct link for the latest Github release.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.36%. Comparing base (7d59bfe) to head (ab6288d).
⚠️ Report is 286 commits behind head on 4.22.

Additional details and impacted files
@@            Coverage Diff            @@
##               4.22   #11429   +/-   ##
=========================================
  Coverage     17.35%   17.36%           
- Complexity    15232    15233    +1     
=========================================
  Files          5885     5885           
  Lines        525618   525619    +1     
  Branches      64157    64157           
=========================================
+ Hits          91225    91252   +27     
+ Misses       424094   424072   -22     
+ Partials      10299    10295    -4     
Flag Coverage Δ
uitests 3.63% <ø> (-0.01%) ⬇️
unittests 18.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

@shwstppr (code lgtm) this will not work on arm base systems will it? Anything we can do about that? (new issue?)

@shwstppr
Copy link
Contributor Author

shwstppr commented Aug 13, 2025

@shwstppr (code lgtm) this will not work on arm base systems will it? Anything we can do about that? (new issue?)

@DaanHoogland I think we'll have to bundle both x86-64 and arm64 binaries and during installation use the correct one. I'll try to check that separately. You may create a new issue if needed

Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14618

@rohityadavcloud rohityadavcloud added this to the 4.22.0 milestone Aug 20, 2025
@shwstppr
Copy link
Contributor Author

shwstppr commented Oct 9, 2025

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15362

@harikrishna-patnala harikrishna-patnala modified the milestones: 4.22.0, 4.22.1 Nov 12, 2025
@shwstppr shwstppr changed the base branch from main to 4.22 December 19, 2025 06:32
@shwstppr shwstppr changed the base branch from 4.22 to 4.20 December 19, 2025 06:33
@shwstppr shwstppr changed the base branch from 4.20 to 4.22 December 19, 2025 06:34
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@apache apache deleted a comment from blueorangutan Dec 19, 2025
@apache apache deleted a comment from blueorangutan Dec 19, 2025
@shwstppr
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Instead listing all GIthub releases first and finding the latest one use
the direct link for the latest Github release.

Signed-off-by: Abhishek Kumar <[email protected]>
@github-actions
Copy link

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16101

@shwstppr
Copy link
Contributor Author

I don't think we need smoke tests here. Just needs a check if the latest cmk got bundled

@DaanHoogland
Copy link
Contributor

tested in a lab env

@DaanHoogland DaanHoogland merged commit 79ab156 into apache:4.20 Dec 19, 2025
1 check passed
@shwstppr shwstppr deleted the cmk-use-latest-release branch December 22, 2025 07:37
@shwstppr shwstppr modified the milestones: 4.22.1, 4.20.3 Dec 22, 2025
DaanHoogland pushed a commit that referenced this pull request Dec 22, 2025
* 4.22:
  Update templateConfig.sh to not break with directorys with space on t… (#10898)
  Fix VM and volume metrics listing regressions (#12284)
  packaging: use latest cmk release link directly (#11429)
  api:rename RegisterCmd.java => RegisterUserKeyCmd.java (#12259)
  Prioritize copying templates from other secondary storages instead of downloading them (#10363)
  Show time correctly in the backup schedule UI  (#12012)
  kvm: use preallocation option for fat disk resize (#11986)
  Python exception processing static routes fixed (#11967)
  KVM memballooning requires free page reporting and autodeflate (#11932)
  api: create/register/upload template with empty template tag (#12234)
@DaanHoogland DaanHoogland removed their assignment Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants