Review all list APIs and make then honour listall parameter

[rohityadavcloud]

There are many list APIs that should ideally honour the listall parameter and when set to true should return all the items a caller/account is authorised to see. Due to a historic use of projectid=-1, most APIs do return all project only resources.

With PR #3894 the behaviour has been addressed for some APIs such as listRouters etc where all resources are returned for root admin when both listall=true and projectid=-1 is passed. A review of all list APIs and fix to make the behaviour consistent is asked.

ISSUE TYPE

• Bug Report
• Improvement Request

COMPONENT NAME

API

CLOUDSTACK VERSION

4.13, 4.14+

[weizhouapache]

@rhtyd Should this be fixed before 4.14.0.0 release ?

[rohityadavcloud]

@weizhouapache I'll need to check if others APIs need to be supported, the changes were done solely to support infrastructure (VR etc) list views in Primate.

[weizhouapache]

@rhtyd will you plan to work on this issue ?

[rohityadavcloud]

@weizhouapache I'm not sure - it would depend on requirement coming from Primate issues/tasks

[wido]

Ping @GabrielBrascher

This is what we ran into as well

[DaanHoogland]

in view of the changes in #3894 it would seem that no further work needs to be done, @rhtyd can you comment?
@wido @weizhouapache did you have anymore issues as a result of this?

[GabrielBrascher]

@rhtyd @DaanHoogland do you think that PR #4276 should extend its goals to more APIs?

Or is it ok to do it "progressively" with different PRs addressing this issue?