FIX - customize theme #718

utchoang · 2020-09-16T03:26:58Z

Fixes #712
Fixes #713
Fixes #714

Customize link hover color
Customize loading color
Customize navigation menu color

@rhtyd cc @svenvogel

utchoang · 2020-09-16T03:31:26Z

Customize link hover color

Customize loading color

yadvr · 2020-09-16T09:17:03Z

@blueorangutan package

blueorangutan · 2020-09-16T09:18:37Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-16T09:27:40Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3479)

utchoang · 2020-09-18T07:34:55Z

Customize navigation color

utchoang · 2020-09-18T07:35:05Z

@blueorangutan package

blueorangutan · 2020-09-18T07:35:30Z

@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-18T07:44:28Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3483)

utchoang · 2020-09-18T07:45:18Z

@blueorangutan package

blueorangutan · 2020-09-18T07:46:30Z

@utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-18T07:55:26Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3484)

yadvr · 2020-09-21T08:28:55Z

LGTM, need bit of testing
@davidjumani @andrijapanicsb can you review/test? Thanks

yadvr · 2020-09-21T11:33:04Z

cc @DaanHoogland

yadvr · 2020-09-21T11:54:53Z

@utchoang code LGTM, can you update the https://github.com/apache/cloudstack-primate/blob/master/docs/customize.md in sync with your FR and the doc https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/primate.rst (you'll need to send a separate PR to the apache/cloudstack-documentation repo). Thanks.

I'll need second pair of testing from @DaanHoogland or @davidjumani thanks

DaanHoogland

I cannot add sensible comments about the code but will give it some test attention

DaanHoogland · 2020-09-21T19:15:57Z

@blueorangutan package

blueorangutan · 2020-09-21T19:17:08Z

@DaanHoogland a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

blueorangutan · 2020-09-21T19:26:22Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3497)

DaanHoogland

tested and looks good.

DaanHoogland · 2020-09-22T07:30:47Z

@utchoang I saw that only the navigation colour can be set. I would expect the main pane to be matching. Does that make sense? Or should it also be a separate colour?

utchoang · 2020-09-22T07:37:05Z

@DaanHoogland Regarding the adjustment of the main page, it takes quite a lot of changes (CSS, style). Can I do it if it's absolutely necessary? @rhtyd thought?

DaanHoogland · 2020-09-22T08:05:36Z

@utchoang It was just an observation with regards to the issue #714 I do consider this a feature (not broderline-) so I do not regard this part of 1.0 ga! I think we should have a full theming/cusitmization issue for 1.1. I think we should merge this and call it a release. I assure you, I'll keep coming up with issues if we don't.

DaanHoogland · 2020-09-22T08:49:21Z

are you updating customize.md in this PR, @utchoang ?

utchoang · 2020-09-22T09:06:21Z

@DaanHoogland Yes. I've updated.

yadvr · 2020-09-22T12:05:39Z

Thanks @utchoang @DaanHoogland lgtm, but I need to do one round of test with a real deb/rpm based package. I'll merge it after that (today/tomorrow).

yadvr · 2020-09-22T12:06:59Z

@utchoang can you send a doc PR to https://github.com/apache/cloudstack-documentation/blob/master/source/installguide/primate.rst#basic-customization-in-cloudstack-primate

yadvr · 2020-09-23T05:50:15Z

@blueorangutan package

blueorangutan · 2020-09-23T05:51:14Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

yadvr · 2020-09-23T05:51:41Z

src/views/AutogenView.vue

          return
        }

-        if ([401].includes(error.response.status)) {


@utchoang why not dispatch logout on 401/unauthorise error?

@rhtyd I don't have changed it. Maybe it's because I haven't merged with the latest master yet.

yadvr · 2020-09-23T05:52:19Z

src/views/compute/DeployVM.vue

    },
    fetchTemplateNics (template) {
      var nics = []
-      if (template && template.deployasisdetails && Object.keys(template.deployasisdetails).length > 0) {


@utchoang why is this part of the PR change?

yadvr · 2020-09-23T05:52:31Z

src/views/iam/DomainView.vue

          duration: 0
        })

-        if ([401].includes(error.response.status)) {


@utchoang same as above?

yadvr · 2020-09-23T06:00:44Z

Tested, LGTM
Verified left nav bar colour for default view:

Project view is still dark-er though:

@utchoang would it be possible to define a custom background colour for the navigation bar on left when we're in a project view (i.e. selected a project)?

blueorangutan · 2020-09-23T06:03:45Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3501)

utchoang · 2020-09-23T06:59:07Z

For select project

yadvr · 2020-09-23T07:00:36Z

Thanks @utchoang pl update the customize.md and send a doc PR to the documentation repo

yadvr · 2020-09-23T07:01:11Z

@blueorangutan package

blueorangutan · 2020-09-23T07:01:14Z

@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

utchoang · 2020-09-23T07:04:03Z

@rhtyd I've updated customize.md on this PR and a document on apache/cloudstack-documentation#159

yadvr · 2020-09-23T07:09:36Z

Thanks @utchoang I'll review, test and merge shortly

blueorangutan · 2020-09-23T07:10:05Z

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/718 (JID-3502)

Customize link hover color Customize loading color Customize navigation menu color Fixes #712 Fixes #713 Fixes #714

add custom support for link hover color and loading color

deb6945

utchoang mentioned this pull request Sep 16, 2020

[BUG] (UI) (borderline feature request) - can't change the navigation menu color for default view or project view #714

Closed

utchoang added 3 commits September 17, 2020 11:34

customize menu color & logo color

0921bcb

Merge branch 'master-upstream' into feature/fix-customize-theme

3a0c088

add customize navigation text color

4249172

customize icon kubernetes color

1172213

yadvr added this to the 1.0-GA milestone Sep 18, 2020

yadvr requested a review from DaanHoogland September 21, 2020 11:53

yadvr approved these changes Sep 21, 2020

View reviewed changes

DaanHoogland self-assigned this Sep 21, 2020

DaanHoogland reviewed Sep 21, 2020

View reviewed changes

DaanHoogland mentioned this pull request Sep 21, 2020

[BUG] '@link-color' does not effect the mouse-over color in details section #712

Closed

DaanHoogland approved these changes Sep 21, 2020

View reviewed changes

add custom option (background/text) for link, menu

01c3e84

yadvr reviewed Sep 23, 2020

View reviewed changes

src/views/iam/DomainView.vue

duration: 0

})

if ([401].includes(error.response.status)) {

Copy link

Member

yadvr Sep 23, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@utchoang same as above?

Merge branch 'master-upstream' into feature/fix-customize-theme

e499a10

Merge branch 'master-upstream' into feature/fix-customize-theme

ced3287

yadvr approved these changes Sep 23, 2020

View reviewed changes

fix custom background color for navigation when switch project

8d66bab

yadvr merged commit 4141842 into apache:master Sep 23, 2020

yadvr mentioned this pull request Sep 23, 2020

[BUG] '@processing' color does not affect the page loading progress or circular 'I'm thinking' graphic #713

Closed

utchoang deleted the feature/fix-customize-theme branch September 23, 2020 09:04

weizhouapache pushed a commit that referenced this pull request Jan 19, 2021

config: extend basic customize theming options (#718)

3519c57

Customize link hover color Customize loading color Customize navigation menu color Fixes #712 Fixes #713 Fixes #714

FIX - customize theme #718

FIX - customize theme #718

Uh oh!

Conversation

utchoang commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

utchoang commented Sep 16, 2020

Uh oh!

yadvr commented Sep 16, 2020

Uh oh!

blueorangutan commented Sep 16, 2020

Uh oh!

blueorangutan commented Sep 16, 2020

Uh oh!

utchoang commented Sep 18, 2020

Uh oh!

utchoang commented Sep 18, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

utchoang commented Sep 18, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

blueorangutan commented Sep 18, 2020

Uh oh!

yadvr commented Sep 21, 2020

Uh oh!

yadvr commented Sep 21, 2020

Uh oh!

yadvr commented Sep 21, 2020

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Sep 21, 2020

Uh oh!

blueorangutan commented Sep 21, 2020

Uh oh!

blueorangutan commented Sep 21, 2020

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Sep 22, 2020

Uh oh!

utchoang commented Sep 22, 2020

Uh oh!

DaanHoogland commented Sep 22, 2020

Uh oh!

DaanHoogland commented Sep 22, 2020

Uh oh!

utchoang commented Sep 22, 2020

Uh oh!

yadvr commented Sep 22, 2020

Uh oh!

yadvr commented Sep 22, 2020

Uh oh!

yadvr commented Sep 23, 2020

Uh oh!

blueorangutan commented Sep 23, 2020

Uh oh!

yadvr Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

utchoang Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

yadvr Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

yadvr Sep 23, 2020

Choose a reason for hiding this comment

Uh oh!

yadvr commented Sep 23, 2020

Uh oh!

blueorangutan commented Sep 23, 2020

utchoang commented Sep 16, 2020 •

edited

Loading