Skip to content
This repository was archived by the owner on Jan 20, 2021. It is now read-only.

Conversation

@davidjumani
Copy link
Contributor

This removes the sessionkey cookie which is passed via the legacy UI that causes credential auth issues
Fixes apache/cloudstack#4136

@davidjumani
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result: ✔️centos ✔️debian ✔️archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/453 (JID-2121)

Copy link
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs testing

@yadvr yadvr added this to the 1.0-GA milestone Jun 24, 2020
@yadvr
Copy link
Member

yadvr commented Jun 24, 2020

Does not solve, two sessionkey cookies seen still:

Cookie: sessionkey=-AL03U08_FMJtQdWlO1mkFIZW_M; JSESSIONID=node0fdxqrpkedzt711zlrg9vkzz3j182.node0; sessionkey=xUGwo6gd2tI7IDh3KfJzdp_yxsc; username=admin; account=admin; domainid=e4874e10-5fdf-11ea-9a56-1e006800018c; role=1; timezone=UTC; timezoneoffset=0.0; userfullname=admin%20cloud; userid=27f2484f-5fe0-11ea-9a56-1e006800018c

@yadvr
Copy link
Member

yadvr commented Jun 24, 2020

does n't solve the issue but i'll merge as Primate shouldn't set sessionkey cookie

@yadvr yadvr merged commit d8d9231 into apache:master Jun 24, 2020
@davidjumani
Copy link
Contributor Author

Tested by opening a private window with both primate and legacy running locally, logging out / in, only one sessionkey cookie was created. Could you explain what was done @rhtyd

yadvr pushed a commit to shapeblue/cloudstack-primate that referenced this pull request Jul 6, 2020
Primate should not set sessionkey cookie
weizhouapache pushed a commit that referenced this pull request Jan 19, 2021
Primate should not set sessionkey cookie
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UI doesn't allow login if sessionkey and JSESSIONID cookies are deleted

3 participants