[BUG] Domain admin cannot create a second user in an account

[DaanHoogland]

Describe the bug
both new and old UI fail but indifferent ways.

To Reproduce
Steps to reproduce the behavior:

1. Log in as a Domain Admin
2. Create a child domain to yours
3. Create a Domain admin account in the child domain
4. try to create a second user in the same account in the child domain

Expected behavior
the user should be created without problem.

• in primate an error is thrown
• in the old UI the child domain cannot be selected to create the user in

Screenshots

Desktop (please complete the following information):

• OS: [e.g. Windows, Mac, iOS, Android with device/screen details if applicable]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Add any other context about the problem here.

[ravening]

@DaanHoogland I was not able to reproduce the issue

1. I have a domain "test" with account name "test" with "domain admin" access and username "test1"
2. Login to the domain admin account with "test1/test1/test" as username/password/domain
3. Now I create one more domain under test with name "test-11"
4. I create a new "domain admin" account with name "test-11-account" and first user with name "test-11-user" under domain "test-11"
5. Now I will try to create another user under account "test-11-account" with name "test-12-user"
6. Didnt see any error

[DaanHoogland]

@ravening the error is when you create account but enter the same name as the original account. a bit of a strange use case but it is documented to work fine. So don't "+ Add User" but "+ Add Account". You see in the help of the account field of that dialog that it is supposed to work.

[ravening]

@ravening the error is when you create account but enter the same name as the original account. a bit of a strange use case but it is documented to work fine. So don't "+ Add User" but "+ Add Account". You see in the help of the account field of that dialog that it is supposed to work.

@DaanHoogland i didn't see add account option while adding second user

[utchoang]

In my opinion, to solve the problem, the field account will be a selection for choosing accounts instead of input. @rhtyd What do you think?

[DaanHoogland]

@utchoang that is not an option as users can also enter a non existing account name to create an account name different than the username

[utchoang]

@DaanHoogland @rhtyd I mean, it will be both an option and an input field that allows creating an account?

[DaanHoogland]

a combibox would be ok, i guess.

[utchoang]

@rhtyd @davidjumani The problem, when I change the accounting field to a Combobox, is when I add an account with accountid selected, there is an error from the API that says Internal error executing command, please contact your system administrator. So is the API side not allowing add accounts in an existing account, right?

[yadvr]

cc @davidjumani @andrijapanicsb - any view on this?

[davidjumani]

@DaanHoogland It looks like the backend checks whether the account exists even though it claims to just create a user if the account exists. Fixed via apache/cloudstack#4353

[davidjumani]

@utchoang This will require a backend fix. I'll change the front end to a dropdown too while I'm at it. Thanks!

[yadvr]

The apidocs for createAccount says:

account                  string   Creates the user under the specified acco
                                  unt. If no account is specified, the use
                                  rname will be used as the account name.

So, this is correct if you're trying to create another account with the same, already existing user name. Instead to add account form, you can go to the account -> view users and add user there.