Disk provisioning types vmware #187
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spaceman1984
force-pushed
the
disk-provisioning-types-vmware
branch
from
26c6b87 to
16fd13d
Compare
sureshanaparti
approved these changes
Feb 25, 2021
Contributor
|
@rhtyd I think the code PR is for 4.16. should this doc-change be marked for 4.15? |
Member
|
🤦 nope you're right @DaanHoogland @Spaceman1984 can you open a PR for master branch, I'll revert the change on 4.15 branch. |
Contributor
Author
|
Created a new pull request #217 |
DaanHoogland
added a commit
that referenced
this pull request
Jun 2, 2021
This reverts commit 2831683.
Contributor
|
revert as PR #218 not sure if we need reviews there @rhtyd so merge at will. |
Member
|
Thanks @DaanHoogland |
yadvr
pushed a commit
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to VMware disk provisioning types.