-
Notifications
You must be signed in to change notification settings - Fork 120
installguide: minor wording and grammar fixes #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
requesting docbuild |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr161 Build Log Output: No log errors found to report. |
8255e0d to
32e10d4
Compare
|
requesting docbuild |
|
Your request had been received, i'll go and build the documentation and check the output log for errors. This shouldn't take long. |
|
Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr161// Build Log Output: No log errors found to report.// |
|
I don't like the over capitalisation taken from anglosaxon media, but overall this looks good. two lgtm so merging |
|
Thank you for the feedback @DaanHoogland. I would be more than happy to create another pull request and reword the titles to use less capitalization, if you want. I just built packages for 4.14. As I install CloudStack again, I figured I would go through the documentation and improve where appropriate. I typically capitalize titles in documentation, but I can understand if they strike a non-neutral tone. I'll remember to use less capitalization for any future CloudStack PRs. |
|
No worries @falcon78921 . thanks you for your contributions. |
Documentation improvements for building CloudStack from source.