Skip to content

Conversation

@falcon78921
Copy link
Contributor

@falcon78921 falcon78921 commented Oct 5, 2020

Documentation improvements for building CloudStack from source.

@yadvr yadvr added this to the 4.15 milestone Oct 5, 2020
@yadvr
Copy link
Member

yadvr commented Oct 5, 2020

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr161

Build Log Output:

No log errors found to report.

@yadvr
Copy link
Member

yadvr commented Oct 23, 2020

requesting docbuild

@ACSGitBot
Copy link

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

@ACSGitBot
Copy link

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr161//

Build Log Output:

No log errors found to report.//

@DaanHoogland
Copy link
Contributor

I don't like the over capitalisation taken from anglosaxon media, but overall this looks good. two lgtm so merging

@DaanHoogland DaanHoogland merged commit b7e0edd into apache:master Dec 11, 2020
@falcon78921 falcon78921 deleted the intro-improvements-1 branch December 15, 2020 02:31
@falcon78921
Copy link
Contributor Author

Thank you for the feedback @DaanHoogland. I would be more than happy to create another pull request and reword the titles to use less capitalization, if you want. I just built packages for 4.14. As I install CloudStack again, I figured I would go through the documentation and improve where appropriate. I typically capitalize titles in documentation, but I can understand if they strike a non-neutral tone. I'll remember to use less capitalization for any future CloudStack PRs.

@DaanHoogland
Copy link
Contributor

No worries @falcon78921 . thanks you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants