Unmanage VMs documentation #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

andrijapanicsb merged 4 commits into apache:master from nvazquez:unmanagevms

Jun 17, 2020

Contributor

nvazquez commented Jun 16, 2020

Functionality PR: apache/cloudstack#4103


          Unmanage VMs documentation

e4e774f

nvazquez requested a review from andrijapanicsb

June 16, 2020 13:34

nvazquez added this to the 4.15 milestone

Contributor Author

nvazquez commented Jun 16, 2020

requesting docbuild

ACSGitBot commented Jun 16, 2020

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot commented Jun 16, 2020

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139

Build Log Output:

No log errors found to report.

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

andrijapanicsb reviewed

View reviewed changes

source/adminguide/virtual_machines/unmanage_vms.rst Outdated Show resolved Hide resolved

Contributor

andrijapanicsb commented Jun 16, 2020 •

edited

Loading

@nvazquez Please consider also documenting:

the "forced" parameter in the importUnmanagedInstance API call - that is new (afaik) in this release/4.15
"diskofferingid" import parameter was removed afaik

nvazquez and others added 2 commits

June 16, 2020 14:16


          Apply suggestions from code review

abad608

Co-authored-by: Andrija Panic <[email protected]>


          Update VM ingestion docs

3caf3d6

Contributor Author

nvazquez commented Jun 16, 2020

Thanks @andrijapanicsb - added


          Refactor forced param description

b37ed46

Contributor Author

nvazquez commented Jun 16, 2020

requesting docbuild

ACSGitBot commented Jun 16, 2020

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

apache deleted a comment from ACSGitBot

apache deleted a comment from ACSGitBot

ACSGitBot commented Jun 16, 2020

Your request had been received, i'll go and build the documentation and check the output log for errors.

This shouldn't take long.

ACSGitBot commented Jun 16, 2020

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139

Build Log Output:

No log errors found to report.

1 similar comment

ACSGitBot commented Jun 16, 2020

Build finished. You can review it at: https://acs-www.shapeblue.com/docs/WIP-PROOFING/pr139

Build Log Output:

No log errors found to report.

Contributor

andrijapanicsb commented Jun 17, 2020

LGTM

andrijapanicsb merged commit 8532e8d into apache:master

nvazquez deleted the unmanagevms branch

June 26, 2020 13:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet