Merged
Conversation
davidcavazos
force-pushed
the
game-streaming
branch
from
5f2cf43 to
a8e09dc
Compare
Member
|
LGTM. Thank you. |
charlesccychen
added a commit
to charlesccychen/beam
that referenced
this pull request
Mar 10, 2018
That change broke execution of hourly_team_score.
charlesccychen
added a commit
to charlesccychen/beam
that referenced
this pull request
Mar 10, 2018
That change broke execution of hourly_team_score.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing streaming samples to work in latest version. Basically just changed to use
beam.io.WriteToBigQueryinstead of usingBigQuerySink. With this, it works both onDirectRunnerandDataflowRunner. Also got rid of theWriteToBigQuerywrapper class, so a some of the code got simplified even further.R: @aaltay