Fix flaky precommit java test on prism caused by PR 35202#35336
Merged
shunping merged 3 commits intoapache:masterfrom Jun 17, 2025
Merged
Fix flaky precommit java test on prism caused by PR 35202#35336shunping merged 3 commits intoapache:masterfrom
shunping merged 3 commits intoapache:masterfrom
Conversation
Collaborator
Author
Collaborator
Author
|
The PreCommit Java test is green (https://github.com/apache/beam/actions/runs/15715290813). |
shunping
added a commit
to shunping/beam
that referenced
this pull request
Jun 17, 2025
* Revert "Reverts apache#35202 (apache#35306)" This reverts commit 71073a0. * Check if type assertion is ok before using it in range. * Trigger PreCommit Java test.
This was referenced Jun 17, 2025
shunping
added a commit
that referenced
this pull request
Jun 17, 2025
* Reverts #35202 (#35306) * Fix flaky precommit java test on prism caused by PR 35202 (#35336) * Revert "Reverts #35202 (#35306)" This reverts commit 71073a0. * Check if type assertion is ok before using it in range. * Trigger PreCommit Java test. --------- Co-authored-by: akashorabek <70029317+akashorabek@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get back #35202 (reverted at #35306) and fix the type assertion issue that causes PreCommit Java test failure.
fixes #35233
The original error can be reproduced by the simple code below:
By adding the ok returned value for type assertion, the error is not raised and ok is False in this case.