Fix for issue 34772 to include user provided providers#35033
Merged
shunping merged 3 commits intoapache:masterfrom Jun 2, 2025
Merged
Fix for issue 34772 to include user provided providers#35033shunping merged 3 commits intoapache:masterfrom
shunping merged 3 commits intoapache:masterfrom
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
|
assign set of reviewers |
Contributor
|
Reviewers are already assigned to this PR: @shunping |
Contributor
Author
|
@shunping Can you please review this PR. |
shunping
requested changes
May 30, 2025
Collaborator
Yes. It looks good overall, but to make things consistent, please correct the flag name. Thanks! |
Collaborator
|
remind me after tests pass |
Contributor
|
Ok - I'll remind @shunping after tests pass |
Contributor
Author
|
@shunping can you please check now? |
shunping
pushed a commit
to shunping/beam
that referenced
this pull request
Jun 6, 2025
* Fix for issue 34772 to include user provided providers * Fix CI checks * Incorporate review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #34772 by adding code changes to consider user provided providers if they are provided via command-line arguments.
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.