[AnomalyDetection] Add Custom Detector to support custom model handlers#34285
Closed
shunping wants to merge 2 commits intoapache:masterfrom
Closed
[AnomalyDetection] Add Custom Detector to support custom model handlers#34285shunping wants to merge 2 commits intoapache:masterfrom
shunping wants to merge 2 commits intoapache:masterfrom
Conversation
shunping
changed the title
shunping
changed the title
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
shunping
force-pushed
the
anomaly-detection-5-2
branch
3 times, most recently
from
e4b375e to
fddbb73
Compare
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @damccorm for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
- torch.Tensor(n) gives a nx1-tensor with zeros: i.e. Tensor(0, 0, ... 0). - torch.tensor(n) gives a 1x1-tensor with value n: i.e. Tensor(n).
shunping
force-pushed
the
anomaly-detection-5-2
branch
from
fddbb73 to
ce275a6
Compare
damccorm
requested changes
Mar 14, 2025
Contributor
damccorm
left a comment
damccorm
left a comment
There was a problem hiding this comment.
Missed that this was a prereq for #34286 (review) and left some high level comments there instead, PTAL
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support offline model scoring with model handler and RunInference, we add a new
AnomalyDetectorclass calledCustomDetectorfor storing model handler and other information. Then we modify our transform to expand the pipeline with RunInference Transform if we see this new type of detctors.This PR only contains the code change for the new detector. The follow-up PR (#34286) is for the transform change.