[AnomalyDetection] Add main and auxiliary transforms.#34234
[AnomalyDetection] Add main and auxiliary transforms.#34234damccorm merged 2 commits intoapache:masterfrom
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
r: @damccorm |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
3d1931e to
2642c70
Compare
2642c70 to
d5aa691
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #34234 +/- ##
============================================
+ Coverage 56.28% 56.35% +0.06%
Complexity 3286 3286
============================================
Files 1166 1173 +7
Lines 178678 179057 +379
Branches 3398 3398
============================================
+ Hits 100575 100910 +335
- Misses 74850 74894 +44
Partials 3253 3253
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| model_id=self._underlying._model_id, | ||
| score=self.score_and_learn(data))])) | ||
|
|
||
| model_state.write(self._underlying) |
There was a problem hiding this comment.
Not a suggestion for this PR, but this would likely benefit from batching so that we don't have to do state reads/writes for every element (we could just do one per batch)
There was a problem hiding this comment.
Right, though I think in the implementation states will be cached and they are not committed to the backend per element.
There was a problem hiding this comment.
That's true - IIRC they are written when we commit, though (when we finish a bundle), which in streaming could be relatively frequently - a group into batches across bundles might help.
Regardless, that is something we can try/tune down the line and not something which needs to come right now
99ed669 to
2ee0393
Compare
|
Run Python_Coverage PreCommit |
|
Run Prism_Python PreCommit 3.12 |
|
I'll merge once checks pass |
Depends on #34232