[KafkaIO] Update tracker and watermark for non-visible progress

[sjvanrossum]

Calls to poll have timed out if ConsumerRecords.empty() is (by reference) equal to the result of poll.
All other instances may have non-visible records at the end of a batch which should be skipped over while still claiming up to the next offset and updating the watermark.

Stacked on top of #34201.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[sjvanrossum]

Run Java_Kafka_IO_Direct PreCommit

[github-actions]

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @robertwb for label java.
R: @ahmedabu98 for label io.
R: @johnjcasey for label kafka.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[chamikaramj]

Any updates ?

[chamikaramj]

@robertwb @ahmedabu98 or @johnjcasey PTAL.

[johnjcasey]

LGTM

[github-actions]

Reminder, please take a look at this pr: @robertwb @ahmedabu98 @johnjcasey

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @kennknowles for label java.
R: @ahmedabu98 for label io.
R: @kennknowles for label kafka.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[ahmedabu98]

Hey @sjvanrossum, are you still working on this? do you need another review?

[sjvanrossum]

@ahmedabu98 this is good to go, just needs another review. :)

[kennknowles]

Latest code changes seem to have LGTM from John. Just needs merge.

[kennknowles]

The commit descriptions look like they should be kept separate. Is that correct?

[sjvanrossum]

@kennknowles the second commit addresses an isolated issue (expected offset does not advance on the error handling path), but it only surfaced as a problem with the changes in the first commit of this PR.