Add Backlog Metrics to Kafka Splittable DoFn Implementation#31281
Merged
johnjcasey merged 2 commits intoapache:masterfrom May 28, 2024
Merged
Add Backlog Metrics to Kafka Splittable DoFn Implementation#31281johnjcasey merged 2 commits intoapache:masterfrom
johnjcasey merged 2 commits intoapache:masterfrom
Conversation
Naireen
changed the title
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @robertwb for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
|
Reminder, please take a look at this pr: @robertwb @johnjcasey |
Contributor
|
LGTM! |
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
3 tasks
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 24, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 25, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 29, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Oct 31, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Nov 12, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Nov 12, 2024
…pache#31281)" This reverts commit fd4368f.
sjvanrossum
added a commit
to sjvanrossum/beam
that referenced
this pull request
Nov 12, 2024
…pache#31281)" This reverts commit fd4368f.
17 tasks
Abacn
pushed a commit
that referenced
this pull request
Nov 13, 2024
…eadFromKafkaDoFn (#32921) * Revert "Set backlog in gauge metric (#31137)" * Revert "Add Backlog Metrics to Kafka Splittable DoFn Implementation (#31281)" This reverts commit fd4368f. * Call reportBacklog in nextBatch to report split metrics more often * Report SDF metrics for the active split/partition after processing a record batch * Use KafkaSourceDescriptor as cache key and log entry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.