[#28543][prism] Implement State API#29712
Conversation
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #29712 +/- ##
==========================================
+ Coverage 37.85% 38.15% +0.30%
==========================================
Files 690 696 +6
Lines 101352 102086 +734
==========================================
+ Hits 38363 38954 +591
- Misses 61395 61514 +119
- Partials 1594 1618 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @riteshghorse for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
I thought I made this a draft PR. I still have a bit more cleanup / deduplication to do Ritesh. Sorry for the inconvenience. |
|
Ready for a look! Thanks for your patience. No rush to get the review in for 2.53.0, it's OK if it's not in the cut. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
riteshghorse
left a comment
There was a problem hiding this comment.
Mostly looks good, one question!
Adds State API handling to Prism.
In particular:
Resolves #28543
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.