Closed
Conversation
Contributor
|
Great -- thanks for digging in on this @byronellis ! |
…dedScan. Swapped test to use that.
added 2 commits
February 21, 2024 19:06
…it into a new implementation instead.
added 4 commits
March 20, 2024 16:19
…'s BatchLoad implementation since this is a pretty close analog. Has the beginnings of dynamic destination support, though doesn't do triggered windows yet (pretty mechanical just haven't done it yet). Successfully writes files and updates the catalog using a keyed pcollection to collect catalog updates. This appears to work much better than just doing it on bundle close, even in test that was causing collisions and performance issues.
…for right now ("failed writes" are really spilled writes not failures)
…o defer conversion to record and eliminates the need to pass through Row
…tifier from table.name(). If it matches the namespace of our catalog, remove the catalog part of the namespace first so things will work properly.
Contributor
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for reads and writes via Iceberg to the Java SDK. At the moment this isn't intended to be used as a standalone IO, but rather to be integrated into a forthcoming catalog representation that should make it easier to work with more structured sources.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.