[#28187] Prism docker env support.#28444
Conversation
Codecov Report
@@ Coverage Diff @@
## master #28444 +/- ##
==========================================
- Coverage 72.33% 72.23% -0.10%
==========================================
Files 681 682 +1
Lines 100355 100515 +160
==========================================
+ Hits 72589 72608 +19
- Misses 26192 26330 +138
- Partials 1574 1577 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @jrmccluskey for label go. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Ah dang it. This is not yet ready. Please disregard. |
|
R: @jrmccluskey This should be OK to look at now. I could make the artifact handling more robust (and not a memory leak), or even set up "prism runner w/container" runs as a pre commit, but I think I'd like those as separate PRs. I don't love the current test coverage, but it seems tricky to do for the time being, and that gets covered by adding the full suite runs. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
Enable support for using docker containers with prism.
Part of #28187
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.