Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions#28390
Conversation
|
Assigning reviewers. If you would like to opt out of this review, comment R: @Abacn for label build. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Dataflow V2 ValidatesRunner jobs (batch/stream) took very long to complete (5-7h) - on Jenkins the schedule was adjusted to every 8 hrs
There was a problem hiding this comment.
Good catch! Bumped to 8 hrs and double checked for other jobs
There was a problem hiding this comment.
let's monitor how this schedule leads to. On Jenkiins the if the second job triggered and the first one not finished, it will be queued until the first one finish / or time out; here it will cancel the previous one. If that happens consider bumping all dataflow validrunner schedule to every 8 hr (or more)
There was a problem hiding this comment.
Consider suffix Java -> JavaVersions ? (Similar to FlinkVersions / SparkVersions we used for workflows with a matrix) - and same as other workflows having Java11/Java17
There was a problem hiding this comment.
Updated. Thanks!
andreydevyatkin
force-pushed
the
beam_PostCommit_Java_ValidatesRunner
branch
2 times, most recently
from
de148b3 to
99677af
Compare
andreydevyatkin
force-pushed
the
beam_PostCommit_Java_ValidatesRunner
branch
from
b0b692c to
7cf61a9
Compare
Codecov Report
@@ Coverage Diff @@
## master #28390 +/- ##
==========================================
- Coverage 72.32% 72.31% -0.01%
==========================================
Files 683 683
Lines 100709 100619 -90
==========================================
- Hits 72834 72765 -69
+ Misses 26297 26279 -18
+ Partials 1578 1575 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
# This is the 1st commit message: added beam_PostCommit_Java_ValidatesRunner jobs to GitHub Actions # This is the commit message #2: Don't improperly filter newly-added elements that overlap with a delete.
2 participants
The following jenkins jobs have been migrated:
How has it been tested?
The jobs have been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
workflow_dispatch)Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.