GA migration and sharding Python Postcommit ML#23312
GA migration and sharding Python Postcommit ML#23312benEng wants to merge 11 commits intoapache:masterfrom
Conversation
|
Successful execution on self-hosted runners: https://github.com/benWize/beam/actions/runs/3084368879 |
Codecov Report
@@ Coverage Diff @@
## master #23312 +/- ##
==========================================
+ Coverage 73.36% 73.91% +0.55%
==========================================
Files 719 737 +18
Lines 97137 104305 +7168
==========================================
+ Hits 71260 77098 +5838
- Misses 24530 25896 +1366
+ Partials 1347 1311 -36
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM! |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
is this ready for review? who should review this? |
| - name: Run :sdks:python:test-suites:dataflow:py${{env.PYTHON_VERSION}}:postCommitITByTestDirectory | ||
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :sdks:python:test-suites:dataflow:py${{env.PYTHON_VERSION}}:postCommitITByTestDirectory |
There was a problem hiding this comment.
the pytorch tests in apache_beam/ml/inference will get skipped because the dependencies won't be installed[1] on the runner with this workflow.
There was a problem hiding this comment.
I added an extra step to run the Gradle task torchInferenceTest
There was a problem hiding this comment.
@AnandInguva is that enough to make this work? Do we need to do the same thing for other frameworks (e.g. sklearn?)
There was a problem hiding this comment.
I think this should be sufficient to run the current ML tests
Co-authored-by: Anand Inguva <34158215+AnandInguva@users.noreply.github.com>
|
Left one more comment. apart from that, LGTM |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @jrmccluskey for label python. Available commands:
|
|
stop reviewer notifications |
|
Stopping reviewer notifications for this pull request: requested by reviewer |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
The migrated workflow was added to CI.md
DO NOT MERGE until the effort to use self-hosted runners is completed #22703
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.