Conversation
Codecov Report
@@ Coverage Diff @@
## master #23241 +/- ##
==========================================
+ Coverage 73.34% 73.35% +0.01%
==========================================
Files 719 712 -7
Lines 97134 96243 -891
==========================================
- Hits 71244 70601 -643
+ Misses 24541 24331 -210
+ Partials 1349 1311 -38
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
LGTM! |
|
Assigning reviewers. If you would like to opt out of this review, comment R: @AnandInguva for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Thanks! This will really help the current huge (>1h) Python PreCommit test suite. Will look into it. |
|
Run Python_PVR_Flink PreCommit |
|
Run Python PreCommit |
Abacn
left a comment
Abacn
left a comment
There was a problem hiding this comment.
Thanks! Left some comment on my view of python precommit splits.
|
|
||
| # This workflow will run the test of python Avro IO class. | ||
|
|
||
| name: Python Avro IO |
There was a problem hiding this comment.
Do we consider AvroIO as part of "core IO" like in Java SDK so this test may be exercised more often (as textio)? CC: @chamikaramj may have more context.
Also, there is not much precommit test for hadoop, we may not need to split it at this point.
There was a problem hiding this comment.
I removed the Hadoop precommit suite, those tests will be running in the remaining python precommit suite in #23451
| uses: ./.github/actions/gradle-command-self-hosted-action | ||
| with: | ||
| gradle-command: :sdks:python:test-suites:tox:py${{env.PYTHON_VERSION}}:testPy${{env.PYTHON_VERSION}}${{matrix.tox-env}} | ||
| arguments: "-Pposargs=apache_beam/io/azure/" No newline at end of file |
There was a problem hiding this comment.
We are splitting azure and gcp out; we may also want to split aws and dataframe, as there are [azure,aws,gcp,dataframe] extra dependencies and each one could have its own precommit test suite.
|
Reminder, please take a look at this pr: @AnandInguva @Abacn |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @pabloem for label python. Available commands:
|
|
LGTM, thanks! |
|
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the PR at any time and @mention a reviewer or discuss it on the dev@beam.apache.org list. Thank you for your contributions. |
4 participants
As part of the migration of Precommit and Postcommit Jobs from Jenkins to GA in self-hosted runners, this PR contains:
The migrated workflows were added to CI.md
DO NOT MERGE until the effort to use self-hosted runners is completed #22703
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.