sharding GCP IO tests from the javaPostCommit task#21800
sharding GCP IO tests from the javaPostCommit task#21800damccorm merged 4 commits intoapache:masterfrom fernando-wizeline:GCP-IO-postcommit-tasks-sharding
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
| timeoutMins: 120, | ||
| triggerPathPatterns: [ | ||
| '^sdks/java/io/google-cloud-platform/.*$', | ||
| '^runners/direct-java/.*$', |
There was a problem hiding this comment.
Remove this trigger path, since a change to the direct runner does not change the correctness of the IOs.
| '^runners/direct-java/.*$', | ||
| ] | ||
| ) | ||
| builder.build { |
There was a problem hiding this comment.
Is this different from the other precommit builder defaults?
There was a problem hiding this comment.
Yeah, they are different. I added the paths to the direct runner and gcp io folders.
Thanks Kenn!
|
There a conflict caused by the other sharding PR, should be easy to fix up. Be sure to check spotless. |
|
Hi @damccorm! Do you know who can help us to merge this one? |
|
Yep, I actually can now! |
|
Nice! |
| dependsOn(":sdks:java:extensions:google-cloud-platform-core:postCommit") | ||
| dependsOn(":sdks:java:extensions:zetasketch:postCommit") | ||
| dependsOn(":sdks:java:io:google-cloud-platform:postCommit") | ||
| dependsOn(":sdks:java:io:debezium:integrationTest") |
There was a problem hiding this comment.
These line were removed in #21804 but added back in this PR. Sounds like a rebase issue. Should do a rebase instead of merge.
There was a problem hiding this comment.
Oh you're right - good catch, I thought that was part of breaking this apart, but it is not. @fernando-wizeline guessing that wasn't intentional?
@Abacn want to put up a PR to remove those lines?
There was a problem hiding this comment.
Oh, this is so embarrassing, sorry.
That is correct, it was not intentional.
There was a problem hiding this comment.
No problem, I should've caught it too! Thanks Yi
5 participants
Removing the job from the javaPostcommit task and adding its own task for GCP IO tests.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.