[BEAM-13925] Add entry files to process new prs and pr updates for PR automation#16950
Merged
lostluck merged 4 commits intoapache:masterfrom Mar 1, 2022
Merged
Conversation
Contributor
Author
lostluck
reviewed
Feb 25, 2022
Contributor
lostluck
left a comment
lostluck
left a comment
There was a problem hiding this comment.
Only one question from me. I don't know enough TS to comment on the specifics though.
scripts/ci/pr-bot/processNewPrs.ts
Outdated
| // 4) Are closed | ||
| // 5) Have already been processed | ||
| // 6) Have notifications stopped | ||
| // 7) The pr doesn't contain the go label (temporary). TODO(damccorm) - remove this when we're ready to roll this out to everyone. |
Contributor
There was a problem hiding this comment.
Question: After this Go only phase, what happens when a PR has multiple labels? Will it try to assign someone from each label, or will it do some sort of consolidation or limit to # reviewers assigned?
Contributor
Author
There was a problem hiding this comment.
It will assign a reviewer from each configured label (though it should only look for one committer)
KonradJanica
approved these changes
Feb 26, 2022
Contributor
Author
|
R: @lostluck for final review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now, we don't have a well defined automated system for staying on top of pull request reviews - we rely on contributors being able to find the correct OWNERS file and committers manually triaging/calling attention to old pull requests. This is the continuation of an effort to improve our automation around this. Design doc for the full effort here Part 1 was #16898
I have the code to handle new prs and pr updates in a repo here - https://github.com/damccorm/beam-pr-bot-demo - this is a subset of the damccorm/beam-pr-bot-demo#1 split up to try to keep reviews manageable. This PR introduces the files used to process new prs and pr updates and it builds on the shared files introduced in the last PR. This contains most of the business logic of the tool. It also contains a .gitignore and Commands.md file I missed in the last PR.
Initially, I am filtering all bot activity prs with the Go label. This is to minimize the blast radius of the automation in case it doesn't work perfectly out the gate or we find it unhelpful. Eventually, I plan on expanding to the rest of the repo.
You can see see the completed portions of the bot in action in damccorm/beam-pr-bot-demo#3 and damccorm/beam-pr-bot-demo#4 (they show different use cases and exercise almost all of the behavior of the bot).
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.