[BEAM-13208][Playground] Separate stderr from stdout for code processing steps#16026
Merged
pabloem merged 13 commits intoapache:masterfrom Nov 23, 2021
Merged
Conversation
…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks
Member
|
can you rebase this please so I can visualize the diffs (and merge once it's ready) ? thanks! |
added 2 commits
November 23, 2021 10:14
separated stdErr and stdOut for compile step
AydarZaynutdinov
force-pushed
the
BEAM-13208-separate-stderr-stdout
branch
from
5778ed6 to
532fc36
Compare
Contributor
Author
|
R: @pabloem |
pabloem
reviewed
Nov 23, 2021
| successChannel <- true | ||
| } | ||
| }(runCmd, successChannel, errorChannel, dataChannel) | ||
| runOutput := streaming.RunOutputWriter{Ctx: ctxWithTimeout, CacheService: cacheService, PipelineId: pipelineId} |
Member
There was a problem hiding this comment.
some users may want to read stderr in the frontend as well as stdout, so maybe it makes sense to write that to the cache as well.
if I remember correctly, LOG data is weitten to stderr, while only System.out.println-type data will be sent to stdout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BEAM-13208]
separate stdErr and stdOut for compile step
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.