[BEAM-13156][Playground] Implement streaming output for the run code logs#15996
Merged
pabloem merged 9 commits intoapache:masterfrom Nov 23, 2021
Merged
[BEAM-13156][Playground] Implement streaming output for the run code logs#15996pabloem merged 9 commits intoapache:masterfrom
pabloem merged 9 commits intoapache:masterfrom
Conversation
…tions (#83) * Update workflows for playground * Attempt to fix tests * Remove continue on error to catch errors * Fix linter problem for backend dockerfile * Update folder to run backend go linter * Moved flutter test to execution via gradle tasks
Contributor
Author
|
R: @pabloem |
implementation of streaming output for run code output
AydarZaynutdinov
force-pushed
the
BEAM-13156-streaming-output
branch
from
2a9a4f1 to
f71e454
Compare
pabloem
reviewed
Nov 23, 2021
Member
pabloem
left a comment
pabloem
left a comment
There was a problem hiding this comment.
this LGTM. I just added a request, and a question to clarify for me.
| } | ||
|
|
||
| // concat prevValue and new value | ||
| str := fmt.Sprintf("%s%s", prevOutput.(string), string(p)) |
Member
There was a problem hiding this comment.
it seems like redis supports an "append" operation that would save us having to get the last value (https://redis.io/commands/append). Maybe we should add this capability? (it's fine to leave for later)
| runCmd := executor.Run(ctxWithTimeout) | ||
|
|
||
| var runError bytes.Buffer | ||
| runOutput := &streaming.RunOutputWriter{Ctx: ctxWithTimeout, CacheService: cacheService, PipelineId: pipelineId} |
Member
There was a problem hiding this comment.
I am a little confused. I think RunOutputWriter fails if there has not been any output, right? what happens at the very begining when there's no output at all? what adds the very first output?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[BEAM-13156]
implementation of streaming output for run code output
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.