[BEAM-22] Implement InProcessEvaluationContext#11
Closed
tgroh wants to merge 1 commit intoapache:masterfrom
Closed
[BEAM-22] Implement InProcessEvaluationContext#11tgroh wants to merge 1 commit intoapache:masterfrom
tgroh wants to merge 1 commit intoapache:masterfrom
Conversation
Member
Author
|
R: @kennknowles |
| import javax.annotation.Nullable; | ||
|
|
||
| /** | ||
| * The evaluation context for the {@link InProcessPipelineRunner}. Contains state shared within |
Contributor
There was a problem hiding this comment.
I assume this is for a specific pipeline running in the InProcessPipelineRunner, right? Maybe say
"The evaluation context for a specific pipeline running in the {@link InProcessPipelineRunner}."
tgroh
force-pushed
the
ippr_evaluation_context
branch
from
87b4c55 to
2635f86
Compare
This is the primary "global state" object for the evaluation of a Pipeline using the InProcessPipelineRunner, and is responsible for properly routing information about the state of the pipeline to transform evaluators. Remove the InProcessEvaluationContext from the InProcessPipelineRunner class, and implement as a class directly. Fix associated imports.
tgroh
force-pushed
the
ippr_evaluation_context
branch
from
75e6168 to
1e76244
Compare
Contributor
|
@bjchambers did you LGTM this? I cannot find. |
Contributor
|
Okay @tgroh claims it's tgroh@2635f86#commitcomment-16659043 |
davorbonaci
added a commit
to GoogleCloudPlatform/DataflowJavaSDK
that referenced
this pull request
Mar 25, 2016
cosmoskitten
pushed a commit
to cosmoskitten/beam
that referenced
this pull request
Apr 10, 2017
merge all changes for dsl_sql_init
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the primary "global state" object for the evaluation of a
Pipeline using the InProcessPipelineRunner, and is responsible for
properly routing information about the state of the pipeline to
transform evaluators.
Remove the InProcessEvaluationContext from the InProcessPipelineRunner
class, and implement as a class directly. Fix associated imports.
Split from the first commit in #3