Skip to content

ARROW-11034: [Rust] remove rustfmt ignore list, fix format#9013

Closed
mqy wants to merge 1 commit intoapache:masterfrom
mqy:ARROW-11034_rustfmt
Closed

ARROW-11034: [Rust] remove rustfmt ignore list, fix format#9013
mqy wants to merge 1 commit intoapache:masterfrom
mqy:ARROW-11034_rustfmt

Conversation

@mqy
Copy link
Contributor

@mqy mqy commented Dec 25, 2020

In this PR:

  • Ignore list is commented out from rustfmt.toml, thus carrgo +stable fmt would not show warnings
  • Two files are re-formatted by nightly, stable: this may avoid formatting problem we had seen in CI (hope so).

Shell commands that I had run:

cargo +nightly-2020-11-24-x86_64 fmt
cargo +1.48.0-x86_64 fmt

@mqy mqy changed the title ARROW-11034: [Rust]: remove rustfmt ignore list, fix format ARROW-11034: [Rust] remove rustfmt ignore list, fix format Dec 25, 2020
@codecov-io
Copy link

Codecov Report

Merging #9013 (4e40312) into master (a4f7c4a) will decrease coverage by 0.00%.
The diff coverage is 68.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9013      +/-   ##
==========================================
- Coverage   82.87%   82.87%   -0.01%     
==========================================
  Files         201      201              
  Lines       49739    49743       +4     
==========================================
+ Hits        41220    41223       +3     
- Misses       8519     8520       +1     
Impacted Files Coverage Δ
rust/parquet/src/record/api.rs 97.88% <66.66%> (-0.13%) ⬇️
rust/datafusion/src/scalar.rs 59.07% <68.75%> (-0.08%) ⬇️
rust/parquet/src/encodings/encoding.rs 95.43% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4f7c4a...4e40312. Read the comment docs.

@github-actions
Copy link

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

I checked this branch out locally and ran these two commands and there were no changes to my local workspace. 🎉

cargo +stable fmt
cargo +nightly-2020-11-24 fmt

@alamb
Copy link
Contributor

alamb commented Dec 27, 2020

Thanks @mqy !

@alamb alamb closed this in a11491c Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants