ARROW-7045: [R] Preserve factor in Parquet roundtrip#6135
Closed
yutannihilation wants to merge 3 commits intoapache:masterfrom
Closed
ARROW-7045: [R] Preserve factor in Parquet roundtrip#6135yutannihilation wants to merge 3 commits intoapache:masterfrom
yutannihilation wants to merge 3 commits intoapache:masterfrom
Conversation
nealrichardson
approved these changes
Jan 7, 2020
Member
nealrichardson
left a comment
nealrichardson
left a comment
There was a problem hiding this comment.
Thanks for this! LGTM
This makes me question whether default_arrow_writer_properties is right or useful, given that both R and Python are no longer using it. Should this store_schema behavior be pushed down to C++? @wesm
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ability to preserve categorical values was introduced in #5077 as the convention of storing a special
ARROW:schemakey in the metadata. To invoke this, we need to callArrowWriterProperties::store_schema().The R binding is already ready for this, but calls
store_schema()only conditionally and usesparquet___default_arrow_writer_properties()by default. Though I don't see the motivation to implement as such in #5451, considering the Python binding always callsstore_schema(), I guess the R code can do the same.