ARROW-6438 [R]: Add bindings for filesystem API#5390
ARROW-6438 [R]: Add bindings for filesystem API#5390romainfrancois wants to merge 13 commits intoapache:masterfrom
Conversation
|
This misses some tests that we can I guess borrow from https://github.com/apache/arrow/blob/ab803e393c9f6873031d0400d1bfe9c039a3b612/python/pyarrow/tests/test_fs.py |
|
@nealrichardson I've added some basic tests. I guess we'd do s3 file system in another PR ? |
|
Yes, we'll do S3 on https://issues.apache.org/jira/browse/ARROW-6439. |
|
Appveyor failed: https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/27494817/job/t9yhu00mpe0pcfkp#L4093 |
nealrichardson
left a comment
There was a problem hiding this comment.
Seems straightforward enough for now. I didn't look closely at the cpp code but it doesn't look controversial. Just a couple of notes, plus the Windows build failure.
|
Looks good except for this documentation warning: https://travis-ci.org/apache/arrow/jobs/586900859#L3378 |
457f128 to
5959b76
Compare
No description provided.