ARROW-6386: [C++][Documentation] Add documentation on interpretation of null slots#5231
Closed
bkietz wants to merge 1 commit intoapache:masterfrom
Closed
ARROW-6386: [C++][Documentation] Add documentation on interpretation of null slots#5231bkietz wants to merge 1 commit intoapache:masterfrom
bkietz wants to merge 1 commit intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5231 +/- ##
=========================================
Coverage ? 65.29%
=========================================
Files ? 497
Lines ? 67538
Branches ? 0
=========================================
Hits ? 44099
Misses ? 23439
Partials ? 0Continue to review full report at Codecov.
|
Member
|
I'm not sure about this. The specification documents don't provide any guidance about computational semantics, only data representation. It is stated elsewhere (I believe?) that the values "underneath" null slots are not defined. |
Member
|
-1. The spec says "Array slots which are null are not required to have a particular value"; I do not think we need to say more on the matter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds explicit not that null slots should be interpreted as an unknown.
The boolean and compare kernels do not currently implement this behavior:
And(null, false) -> nullCompare(GREATER_EQUAL, null, 0U) -> null