Skip to content

ARROW-2917: [Python] Use detach() to avoid PyTorch gradient errors #2311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alok wants to merge 2 commits into from
Closed

ARROW-2917: [Python] Use detach() to avoid PyTorch gradient errors #2311

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8e298f
Use detach() to avoid torch gradient errors
alok Jul 23, 2018
e451de8
Add unit test serializing pytorch tensor requiring gradiant that fail…
wesm Jul 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/pyarrow/serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ def register_torch_serialization_handlers(serialization_context):
import torch

def _serialize_torch_tensor(obj):
return obj.numpy()
return obj.detach().numpy()

def _deserialize_torch_tensor(data):
return torch.from_numpy(data)
Expand Down
4 changes: 4 additions & 0 deletions python/pyarrow/tests/test_serialization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,10 @@ def test_torch_serialization(large_buffer):
serialization_roundtrip(obj, large_buffer,
context=serialization_context)

tensor_requiring_grad = torch.randn(10, 10, requires_grad=True)
serialization_roundtrip(tensor_requiring_grad, large_buffer,
context=serialization_context)


def test_numpy_immutable(large_buffer):
obj = np.zeros([10])
Expand Down