-
Notifications
You must be signed in to change notification settings - Fork 4k
Open
Labels
Component: C++Component: PythonStatus: stale-warningIssues and PRs flagged as stale which are due to be closed if no indication otherwiseIssues and PRs flagged as stale which are due to be closed if no indication otherwiseType: enhancement
Description
Describe the enhancement requested
With the work in #33984 support for DLPack (exporting) will be added to Arrays. It would be great to do similar for FixedShapeTensorArray (and Tensor) classes.
I would like to open a discussion to decide how to approach the implementation of tensor protocol in case of FixedShapeTensorArray.
If we follow the same logic for FixedShapeTensorArray as in #38472 the dimensionality of the object would change as the tensor extension type array is an array of tensors and not a single tensor. This is not necessarily the right approach. Maybe it would make more sense to apply DLPack support to FixedShapeTensorScalar.
Will be happy to receive feedback on this!
cc @jorisvandenbossche @rok
Component(s)
C++, Python
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Component: C++Component: PythonStatus: stale-warningIssues and PRs flagged as stale which are due to be closed if no indication otherwiseIssues and PRs flagged as stale which are due to be closed if no indication otherwiseType: enhancement