Minor: Document pattern for accessing views in StringView#6673
Merged
alamb merged 1 commit intoapache:masterfrom Nov 4, 2024
Merged
Minor: Document pattern for accessing views in StringView#6673alamb merged 1 commit intoapache:masterfrom
alamb merged 1 commit intoapache:masterfrom
Conversation
austin362667
approved these changes
Nov 2, 2024
Contributor
austin362667
left a comment
austin362667
left a comment
There was a problem hiding this comment.
That's really nice! Much appreciate it @alamb 👍
tustvold
reviewed
Nov 4, 2024
Comment on lines
+59
to
+60
| /// Comparing two `GenericByteViewArray` using PartialEq compares by structure | ||
| /// (the `u128`s) and contents of the buffers, not by logical content. As there |
Contributor
There was a problem hiding this comment.
IMO this is a bug, the other array data equality implementations compute logical equality
tustvold
approved these changes
Nov 4, 2024
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
LGTM, although I think the PartialEq situation is a bug that should be fixed
Contributor
Author
Tracked in #6679 |
Contributor
Author
|
Thank you for the reviews @austin362667 @tustvold and @jayzhan211 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
While reviewing #6671 (review) from @austin362667 I got nerdsniped trying to find documentation on how to work with the views of the StringView
What changes are included in this PR?
GenericByteViewArrayu128viewsAre there any user-facing changes?
Better docs. No functional changes