Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
- Coverage 91.72% 91.62% -0.10%
==========================================
Files 11 11
Lines 749 752 +3
==========================================
+ Hits 687 689 +2
- Misses 62 63 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
spacewander
reviewed
Sep 18, 2022
| # from writing to it if the APISIX is run under root. | ||
| os.chmod(self.fd, 0o766) | ||
| if os.stat(self.fd).st_mode & 0xfff != 0o766: | ||
| raise Exception("can't change mode for unix socket permission to 766") |
Member
There was a problem hiding this comment.
Could you update the CI configuration so the e2e test can pass?
We need to adjust the port of Admin API.
Member
Author
|
OK, I'll finish it soon.
获取 Outlook for iOS<https://aka.ms/o0ukef>
________________________________
发件人: 罗泽轩 ***@***.***>
发送时间: Sunday, September 18, 2022 8:08:27 PM
收件人: apache/apisix-python-plugin-runner ***@***.***>
抄送: Young ***@***.***>; Author ***@***.***>
主题: Re: [apache/apisix-python-plugin-runner] fix: socket file permission (PR #55)
@spacewander commented on this pull request.
________________________________
In apisix/runner/server/server.py<#55 (comment)>:
@@ -84,6 +84,12 @@ def __init__(self, config: NewServerConfig):
self.sock.bind(self.fd)
self.sock.listen(1024)
+ # the default socket permission is 0755, which prevents the 'nobody' worker process
+ # from writing to it if the APISIX is run under root.
+ os.chmod(self.fd, 0o766)
+ if os.stat(self.fd).st_mode & 0xfff != 0o766:
+ raise Exception("can't change mode for unix socket permission to 766")
Could you update the CI configuration so the e2e test can pass?
We need to adjust the port of Admin API.
―
Reply to this email directly, view it on GitHub<#55 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALRIROF4QP6MSOGRG3XS3ALV64A3XANCNFSM6AAAAAAQOA3XPE>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
spacewander
approved these changes
Sep 19, 2022
Member
|
Maybe we can deal with codecov in the next PR? |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: #53
changes:
cc @spacewander