Merged
Conversation
Member
|
@IfDougelseSa Originally, this notification plugin was designed to provide consistent notification functionality when users log in with the same account. For example, logging in with Slack would trigger corresponding Slack notifications. Of course, the scenario you mentioned is indeed an issue—users can configure different login methods and notification channels. Therefore, our recommendation is to retain both query methods. By default, it will use |
LinkinStars
requested changes
Dec 25, 2025
LinkinStars
approved these changes
Dec 29, 2025
Member
LinkinStars
left a comment
There was a problem hiding this comment.
Thank you for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes plugin notifications for SSO-authenticated users by querying the SSO provider's external_id instead of using the notification plugin's name.
Problem
Plugin notifications were failing for users authenticated via SSO (GitHub OAuth, Google, SAML, etc.) because the code was looking up
external_idusing the notification plugin's name instead of the SSO authentication provider.Example:
provider = "github"(SSO)provider = "discord"(notification plugin)ReceiverExternalIDis emptySolution
Query all external logins for the user and use the most recent one (ORDER BY updated_at DESC).
Changes
ORDER BY updated_at DESCtoGetUserExternalLoginListTesting
Before:
Receiver External ID: ← Empty
After:
Receiver External ID: 81540136 ← Populated
Tested with GitHub OAuth SSO and test notification plugin.