Add run type legend tooltip to grid view#61632
Add run type legend tooltip to grid view#61632andreahlert wants to merge 11 commits intoapache:mainfrom
Conversation
andreahlert
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:translations
area:UI
|
Could you help attach screenshot for your changes, thanks! |
|
Updated the PR description. Its part of #28737 but there are other items on the issue. |
Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
…d.tsx Co-authored-by: Pierre Jeambrun <pierrejbrun@gmail.com>
|
Let me know when this is ready for another review. (one comment still needs to be addressed and CI is not happy, but that doens't seem related though, just pushing a new commit should restart it) |
None of the failing CI jobs are related to my changes (React UI: Logs.test.tsx; constraints: Python). Happy to fix if you guys prefer, but the PR itself doesn’t touch those areas. |
…d.tsx Co-authored-by: Brent Bovenzi <brent.bovenzi@gmail.com>
Add an info icon next to the keyboard shortcut icon in the grid view that shows a tooltip with each DAG run type and its corresponding icon (Scheduled, Manual, Backfill, Asset Triggered). Based on apache#61632, with review comments addressed.
|
I'm not sure why the PR was closed, here is a followup PR that addresses the small nits so it can be merged #62946 |
|
@pierrejeambrun I'm not sure what happened to. I was reviewing multiple PRs, this one was closed by accident i think. But we can keep your new one. |
Add an info icon next to the keyboard shortcut icon in the grid view that shows a tooltip with each DAG run type and its corresponding icon (Scheduled, Manual, Backfill, Asset Triggered). Based on apache#61632, with review comments addressed.
Add an info icon next to the keyboard shortcut icon in the grid view that shows a tooltip with each DAG run type and its corresponding icon (Scheduled, Manual, Backfill, Asset Triggered). Based on #61632, with review comments addressed.
Add an info icon next to the keyboard shortcut icon in the grid view that shows a tooltip with each DAG run type and its corresponding icon (Scheduled, Manual, Backfill, Asset Triggered). Based on apache#61632, with review comments addressed.
6 participants
Related #28737.
This adds a small info icon (ℹ) next to the existing keyboard shortcut icon in the grid view. On hover, it displays a tooltip showing each DAG run type with its corresponding icon:
The previous attempt (#51736) was closed due to performance issues with Chakra tooltips on large grids and bad UX with truncated markdown notes. This implementation keeps things simple by reusing the existing
Tooltipcomponent (same as the keyboard shortcut tooltip) and theRunTypeIconcomponent already used throughout the grid.Note indicators were left out of scope since the grid API responses (
GridRunsResponse,LightGridTaskInstanceSummary) don't include note fields.Changes:
GridLegendcomponent inlayouts/Details/Grid/GridLegend.tsxGridLegendtoPanelButtons.tsx(grid-only section)legendtranslation key todag.json