Add dag grid view e2e testing scaffolding#60181
Add dag grid view e2e testing scaffolding#60181Rishikesh63 wants to merge 4 commits intoapache:mainfrom
Conversation
Rishikesh63
force-pushed
the
dag-grid-view-testing
branch
2 times, most recently
from
4905742 to
d969967
Compare
|
@vatsrahul1001 could you please review |
|
Can we rebase and double check that the tests still pass? |
Rishikesh63
force-pushed
the
dag-grid-view-testing
branch
from
d969967 to
8c43562
Compare
yes |
Rishikesh63
force-pushed
the
dag-grid-view-testing
branch
from
8c43562 to
1fc39ea
Compare
|
@vatsrahul1001 @choo121600 could you please review |
| import { BasePage } from "tests/e2e/pages/BasePage"; | ||
|
|
||
| /** | ||
| * DAG Detail Page Object |
There was a problem hiding this comment.
We’ve agreed to use “Dag” instead of “DAG” going forward,
so could you please update the occurrences of “DAG” to “Dag” accordingly?
[VOTE] results as of https://lists.apache.org/thread/0651j4vdgzmlhgndmotvznlg97kyh328
|
|
||
| if (gridCellCount > 0) { | ||
| // If runs exist, wait for first grid cell to be visible | ||
| await this.page.locator('a[id^="grid-"]').first().waitFor({ state: "visible", timeout: 10_000 }); |
There was a problem hiding this comment.
Would it make sense to use expect(locator).toBeVisible() pattern here instead of waitFor?
It gives us an assertion with built-in waiting and clearer failure messages.
|
@Rishikesh63 can you address review comments ? |
could you please unassign this issue,my laptop is facing some issue i have given it for servicing |
|
The original issue has been resolved by #60856. Thanks for your time and feel free to pick another issue to work on. |
5 participants
This PR adds comprehensive Playwright-based E2E tests for the DAG Grid View UI.
The tests verify:
closes: #59539
related: #59028