Restore ability to mark task groups as success/failed in UI by arjav1528 · Pull Request #60161 · apache/airflow

arjav1528 · 2026-01-06T11:56:04Z

Description

This PR adds two new React components that restore the task group marking functionality:

MarkGroupTaskInstanceAsButton - A dropdown button component that allows users to select a state (success/failed) and opens a dialog for confirmation
MarkGroupTaskInstanceAsDialog - A dialog component that provides:
- Options to include past/future/upstream/downstream task instances
- Dry-run preview showing which task instances will be affected
- Ability to add notes to the state change
- Bulk update using the task instance bulk API for efficiency

The button is integrated into the Group Task Instance page header, alongside the existing Clear button.

Screenshots

Solves #60121

Closes: #56103

bohdan-pd · 2026-01-06T12:31:14Z

@arjav1528 Thank you for working on that! 👍

arjav1528 · 2026-01-06T18:56:29Z

@arjav1528 Thank you for working on that! 👍

is the UI ok or do you want me to refactor that

bbovenzi

Thanks for taking this on! Do you mind doing more manually testing to find where MarkAs isn't quite working? I think there are some issues with the API that we need to tackle before we can merge any UI changes.

bbovenzi

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

arjav1528 · 2026-01-07T19:50:01Z

I tried using this locally and still had issues. Could you both manually test this out and also add fastapi test for dry runs?

Sorry about the trouble. I’ve tested this locally and couldn’t reproduce the issue. I have reproduced the issue, solved it, you can run it locally now

…ate update logic and removing listener triggers

…ion for improved clarity and reuse in task instance patching

… ID, including dry run functionality and improved state management

…sk_instances.py Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>

… affected instances and streamline updates for both single task instances and task groups

… instances in patching process

…points, enhancing dry run functionality and validation logic

…sk_instances.py Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>

…llection of unique task instances in patching logic

… based on test group and downgrade SQLAlchemy flag

…tances to ensure correct handling of failed states

…r improved clarity and consistency

…up_id over identifier, improving error handling and validation flow

…ce function to simplify code and improve readability

…fier for task group, enhancing clarity in API requests

… for task group, improving API request structure

…bulk update logic to remove dry_run parameter for improved clarity

… for consistency across test groups

…y and consistency in API requests

guan404ming · 2026-02-20T14:27:56Z

Feel free to let us know if this one is ready for next round review. Thanks!

potiuk · 2026-03-11T19:41:35Z

@arjav1528 This PR has been converted to draft because it does not yet meet our Pull Request quality criteria.

Issues found:

❌ Merge conflicts: This PR has merge conflicts with the main branch. Your branch is 884 commits behind main. Please rebase your branch (git fetch origin && git rebase origin/main), resolve the conflicts, and push again. See contributing quick start.
❌ Pre-commit / static checks: Failing: CI image checks / Static checks. Run prek run --from-ref main locally to find and fix issues. See Pre-commit / static checks docs.
⚠️ Unresolved review comments: This PR has 19 unresolved review threads from maintainers. Please review and resolve all inline review comments before requesting another review. You can resolve a conversation by clicking 'Resolve conversation' on each thread after addressing the feedback. See pull request guidelines.

Note: Your branch is 884 commits behind main. Some check failures may be caused by changes in the base branch rather than by your PR. Please rebase your branch and push again to get up-to-date CI results.

What to do next:

The comment informs you what you need to do.
Fix each issue, then mark the PR as "Ready for review" in the GitHub UI - but only after making sure that all the issues are fixed.
Maintainers will then proceed with a normal review.

Converting a PR to draft is not a rejection — it is an invitation to bring the PR up to the project's standards so that maintainer review time is spent productively. If you have questions, feel free to ask on the Airflow Slack.

bbovenzi · 2026-04-07T20:35:07Z

@arjav1528 Any progress on Pierre's review? We definitely will need to rebase this.

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Restores “mark task group as success/failed” in the UI by adding task-group mark-as components and extending the Task Instance API to support task-group targeting and dry-run previews.

Changes:

Added UI components/hooks for marking task groups and bulk/dry-run updates.
Extended FastAPI Task Instance patch/dry-run routes to accept task_group_id and added a new bulk dry-run endpoint.
Updated OpenAPI generated client/types and added unit tests (Python + UI) around the new behavior.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
airflow-core/tests/unit/api_fastapi/core_api/routes/public/test_task_instances.py	Adds coverage for `task_group_id` patch/dry-run and bulk dry-run behavior; updates existing expectations.
airflow-core/src/airflow/ui/src/queries/usePatchTaskInstanceDryRun.ts	Passes new `identifier` field required by updated OpenAPI path.
airflow-core/src/airflow/ui/src/queries/usePatchTaskInstance.ts	Updates mutation variable typing to align with new OpenAPI request shape.
airflow-core/src/airflow/ui/src/queries/usePatchTaskGroupDryRun.ts	Introduces hook for task-group dry-run via Task Instance dry-run endpoint.
airflow-core/src/airflow/ui/src/queries/usePatchTaskGroup.ts	Adds mutation hook to patch task-group instances and invalidate relevant caches.
airflow-core/src/airflow/ui/src/queries/useBulkUpdateTaskInstancesDryRun.ts	Adds UI hook intended to call new bulk dry-run behavior.
airflow-core/src/airflow/ui/src/queries/useBulkUpdateTaskInstancesDryRun.test.ts	Tests the dry-run hook request shape and caching behavior.
airflow-core/src/airflow/ui/src/queries/useBulkUpdateTaskInstances.ts	Adds wrapper hook for the bulk TI update API plus cache invalidations/toasts.
airflow-core/src/airflow/ui/src/queries/useBulkUpdateTaskInstances.test.ts	Adds unit tests for bulk update hook behavior (success + error).
airflow-core/src/airflow/ui/src/pages/TaskInstance/Header.tsx	Updates patch calls to include `identifier`.
airflow-core/src/airflow/ui/src/pages/GroupTaskInstance/Header.tsx	Adds the new “Mark as” dropdown into the group TI header actions.
airflow-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkTaskInstanceAsDialog.tsx	Updates patch calls to include `identifier`.
airflow-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx	Adds the new dialog UX for task-group mark-as with options + dry-run preview + notes.
airflow-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.test.tsx	Adds unit tests for the new dialog behavior and hook call wiring.
airflow-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsButton.tsx	Adds the dropdown button + hotkeys to open the dialog with selected state.
airflow-core/src/airflow/ui/src/components/Clear/TaskInstance/ClearTaskInstanceDialog.tsx	Updates patch calls to include `identifier`.
airflow-core/src/airflow/ui/openapi-gen/requests/types.gen.ts	Regenerates types for updated TI endpoints and adds bulk dry-run types.
airflow-core/src/airflow/ui/openapi-gen/requests/services.gen.ts	Regenerates service methods/paths including TI identifier and bulk dry-run endpoint.
airflow-core/src/airflow/ui/openapi-gen/queries/queries.ts	Regenerates query/mutation hooks for updated TI endpoints and adds bulk dry-run mutation.
airflow-core/src/airflow/ui/openapi-gen/queries/common.ts	Adds the generated result type for bulk TI dry-run.
airflow-core/src/airflow/api_fastapi/core_api/services/public/task_instances.py	Implements task-group TI selection, unique-TI collection helper, and bulk dry-run handling.
airflow-core/src/airflow/api_fastapi/core_api/routes/public/task_instances.py	Extends TI patch/dry-run routes for task groups and adds `/taskInstances/dry_run` endpoint.
airflow-core/src/airflow/api_fastapi/core_api/openapi/v2-rest-api-generated.yaml	Updates OpenAPI paths/params for identifier-based endpoints and adds bulk dry-run path.
.github/workflows/run-unit-tests.yml	Tweaks comment around TOTAL_TEST_TIMEOUT.

Copilot · 2026-04-10T19:59:35Z

+        query: {
+          dry_run: true,
+        },
+        url: "/api/v2/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances",


The backend route added in this PR is PATCH /api/v2/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/dry_run (path suffix), but this hook calls /taskInstances with dry_run=true query param. This mismatch will cause 404s and break the UI dry-run. Update the hook to call the new /taskInstances/dry_run endpoint (or switch to the generated TaskInstanceService.bulkTaskInstancesDryRun / useTaskInstanceServiceBulkTaskInstancesDryRun).

Suggested change

query: {

dry_run: true,

},

url: "/api/v2/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances",

url: "/api/v2/dags/{dag_id}/dagRuns/{dag_run_id}/taskInstances/dry_run",

Copilot · 2026-04-10T19:59:35Z

+    expect(mockRequest).toHaveBeenCalledWith(
+      expect.anything(),
+      expect.objectContaining({
+        method: "PATCH",
+        path: {
+          dag_id: "test-dag",
+          dag_run_id: "test-run",
+        },
+        query: {
+          dry_run: true,
+        },
+      }),
+    );


This test locks in the (now incorrect) client contract of calling /taskInstances with dry_run=true. If the hook is updated to use the new /taskInstances/dry_run endpoint, update this assertion to validate the correct URL and remove the dry_run query expectation. This is required to prevent the test suite from passing while the UI remains incompatible with the API.

Copilot · 2026-04-10T19:59:36Z

 def patch_task_instance(
    dag_id: str,
    dag_run_id: str,
-    task_id: str,
    dag_bag: DagBagDep,
    body: PatchTaskInstanceBody,
    user: GetUserDep,
    session: SessionDep,
+    identifier: str | None = None,
+    task_id: str | None = None,
    map_index: int | None = None,
+    task_group_id: str | None = Query(None, description="Task group id to update task instances for"),
    update_mask: list[str] | None = Query(None),
 ) -> TaskInstanceCollectionResponse:


This endpoint’s path is .../taskInstances/{identifier}, but identifier is declared optional and there is also a task_id query parameter that can override which task is actually patched. That allows requests like /taskInstances/foo?task_id=bar, where the modified resource doesn’t match the URL path, and it also generates an OpenAPI schema with nullable path params (invalid for required path segments). Make identifier: str (no default) and remove the task_id query parameter from this route; keep task_group_id as the selector for group updates.

Copilot · 2026-04-10T19:59:36Z

+          anyOf:
+          - type: string
+          - type: 'null'


The generated OpenAPI marks the identifier path parameter as nullable (string | null). Path params cannot be null when the segment is required. This comes from the FastAPI signature using identifier: str | None = None. Update the route signatures so required path params are non-optional (str with no default), then regenerate the OpenAPI spec/client.

Suggested change

anyOf:

- type: string

- type: 'null'

type: string

Copilot · 2026-04-10T19:59:36Z

+    toaster.create({
+      description: error.message,
+      title: translate("toaster.update.error", {
+        resourceName: translate("taskGroup"),


This hook is for bulk updating task instances, but the error toast uses resourceName: translate(\"taskGroup\"), which will produce a misleading error title in non-task-group contexts. Use the task-instance translation key (consistent with other TI toasts, e.g. taskInstance_one) or make the resource name configurable via props.

Suggested change

resourceName: translate("taskGroup"),

resourceName: translate("taskInstance_one"),

Copilot · 2026-04-10T19:59:36Z

+      include_past: past,
+      include_upstream: upstream,
+      new_state: state,
+      note,


The dry-run request includes note, but notes don’t affect which task instances are selected; including it increases request churn (and if the dry-run hook’s cache key doesn’t include note, it can lead to confusing cache behavior while typing). Prefer omitting note from dry-run requests, or (if the API intentionally echoes note-related data) include note in the dry-run queryKey so caching stays consistent.

Suggested change

note,

Copilot · 2026-04-10T19:59:37Z

+                    for ti in affected_tis:
+                        ti_key = (
+                            ti.dag_id,
+                            ti.run_id,
+                            ti.task_id,
+                            ti.map_index if ti.map_index is not None else -1,
+                        )
+                        if ti_key not in seen_ti_keys:
+                            seen_ti_keys.add(ti_key)
+                            all_affected_tis.append(ti)


This manually re-implements unique task instance collection logic. Since _collect_unique_tis(...) is introduced in the same module and already encapsulates this behavior, reuse it here (and in the other loop below) to avoid duplication and ensure keying stays consistent across endpoints.

Suggested change

for ti in affected_tis:

ti_key = (

ti.dag_id,

ti.run_id,

ti.task_id,

ti.map_index if ti.map_index is not None else -1,

)

if ti_key not in seen_ti_keys:

seen_ti_keys.add(ti_key)

all_affected_tis.append(ti)

_collect_unique_tis(affected_tis, seen_ti_keys, all_affected_tis)

arjav1528 requested review from bbovenzi, guan404ming, pierrejeambrun, ryanahamilton, shubhamraj-git and vatsrahul1001 as code owners January 6, 2026 11:56

boring-cyborg Bot added the area:UI Related to UI/UX. For Frontend Developers. label Jan 6, 2026

arjav1528 force-pushed the main branch 2 times, most recently from 5db3cd8 to c9d177e Compare January 6, 2026 18:50

arjav1528 marked this pull request as draft January 6, 2026 18:50

arjav1528 marked this pull request as ready for review January 6, 2026 18:50

arjav1528 force-pushed the main branch from c9d177e to c112fef Compare January 6, 2026 19:38

bbovenzi reviewed Jan 6, 2026

View reviewed changes

Comment thread ...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx Outdated

Comment thread ...low-core/src/airflow/ui/src/components/MarkAs/TaskInstance/MarkGroupTaskInstanceAsDialog.tsx Outdated

arjav1528 force-pushed the main branch from c112fef to 6797ea1 Compare January 7, 2026 03:40

arjav1528 requested review from bugraoz93, ephraimbuddy, jason810496, potiuk and rawwar as code owners January 7, 2026 05:08

bbovenzi reviewed Jan 7, 2026

View reviewed changes

Comment thread providers/snowflake/tests/unit/snowflake/hooks/test_snowflake_sql_api.py Outdated

arjav1528 force-pushed the main branch 2 times, most recently from b068b63 to da03292 Compare January 7, 2026 16:39

bbovenzi reviewed Jan 7, 2026

View reviewed changes

arjav1528 force-pushed the main branch 3 times, most recently from d24fdae to 34153d8 Compare January 8, 2026 13:12

arjav1528 requested a review from choo121600 as a code owner January 8, 2026 13:12

arjav1528 and others added 20 commits February 6, 2026 02:35

refactor: streamline task instance state patching by consolidating st…

64120ec

…ate update logic and removing listener triggers

refactor: extract request body validation logic into a separate funct…

48605bb

…ion for improved clarity and reuse in task instance patching

feat: enhance task instance patching to support updates by task group…

cbe4b15

… ID, including dry run functionality and improved state management

Update airflow-core/src/airflow/api_fastapi/core_api/routes/public/ta…

7bd3ea0

…sk_instances.py Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>

refactor: improve task instance state patching logic to handle unique…

138631e

… affected instances and streamline updates for both single task instances and task groups

refactor: remove unnecessary database refresh logic for affected task…

4fd40af

… instances in patching process

feat: add support for optional task_id and task_group_id in patch end…

09c23ab

…points, enhancing dry run functionality and validation logic

Update airflow-core/src/airflow/api_fastapi/core_api/routes/public/ta…

ecf23c5

…sk_instances.py Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>

refactor: introduce _collect_unique_tis function to streamline the co…

28c24dc

…llection of unique task instances in patching logic

chore: update TOTAL_TEST_TIMEOUT in CI workflow to dynamically adjust…

58d819d

… based on test group and downgrade SQLAlchemy flag

fix: update map_indexes and state in test cases for patching task ins…

6e56ddc

…tances to ensure correct handling of failed states

feat: add identifier parameter to task instance patching functions fo…

39b5be5

…r improved clarity and consistency

fix: replace ActionButton usage in MarkGroupTaskInstanceAsButton

bcaf588

refactor: enhance task instance patching logic to prioritize task_gro…

3ba46fa

…up_id over identifier, improving error handling and validation flow

refactor: remove redundant response construction in patch_task_instan…

6c2d8d8

…ce function to simplify code and improve readability

refactor: update URL structure in usePatchTaskGroup to utilize identi…

6892251

…fier for task group, enhancing clarity in API requests

refactor: update URL in usePatchTaskGroupDryRun to include identifier…

23136d3

… for task group, improving API request structure

feat: add bulk task instances dry run endpoint and refactor existing …

bc53be8

…bulk update logic to remove dry_run parameter for improved clarity

chore: set TOTAL_TEST_TIMEOUT to a fixed value of 3600 in CI workflow…

b58d603

… for consistency across test groups

refactor: update dry run endpoint URL in test cases to improve clarit…

657b80b

…y and consistency in API requests

arjav1528 force-pushed the dev-issue-56103 branch from 5df0117 to 657b80b Compare February 5, 2026 21:18

OscarLigthart mentioned this pull request Mar 3, 2026

feat: implement patching of task group instances in API #62812

Open

1 task

potiuk marked this pull request as draft March 11, 2026 19:41

vatsrahul1001 removed this from the Airflow 3.2.0 milestone Mar 27, 2026

kaxil requested a review from Copilot April 10, 2026 19:55

Copilot started reviewing on behalf of kaxil April 10, 2026 19:56 View session

Copilot AI reviewed Apr 10, 2026

View reviewed changes

	resourceName: translate("taskGroup"),
	resourceName: translate("taskInstance_one"),

Conversation

arjav1528 commented Jan 6, 2026 • edited by pierrejeambrun Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

Solves #60121

Closes: #56103

Uh oh!

bohdan-pd commented Jan 6, 2026

Uh oh!

arjav1528 commented Jan 6, 2026

Uh oh!

bbovenzi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bbovenzi left a comment

Choose a reason for hiding this comment

Uh oh!

arjav1528 commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

guan404ming commented Feb 20, 2026

Uh oh!

potiuk commented Mar 11, 2026

Uh oh!

bbovenzi commented Apr 7, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

arjav1528 commented Jan 6, 2026 •

edited by pierrejeambrun

Loading

arjav1528 commented Jan 7, 2026 •

edited

Loading