Conversation
…ort override env variables (#56132) After #55824, colored logs were being emitted even when the terminal was not interactive, causing failures. Environment variables to force color to be turned on or off were also not being respected. This resolves those issues and adds unit tests with all combinations of factors to determine if logs should be colored. (cherry picked from commit d08c2d2) Co-authored-by: Ramit Kataria <ramitkat@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #55824, colored logs were being emitted even when the terminal was
not interactive, causing failures. Environment variables to force color
to be turned on or off were also not being respected.
This resolves those issues and adds unit tests with all combinations of
factors to determine if logs should be colored.
(cherry picked from commit d08c2d2)
Co-authored-by: Ramit Kataria ramitkat@amazon.com