Replace defaultValue with value in TaskTrySelect#56141
Merged
pierrejeambrun merged 5 commits intoapache:mainfrom Sep 30, 2025
Merged
Replace defaultValue with value in TaskTrySelect#56141pierrejeambrun merged 5 commits intoapache:mainfrom
pierrejeambrun merged 5 commits intoapache:mainfrom
Conversation
Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
vedantmamgain
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
1 task
Contributor
|
Makes sense. Do you mind running |
Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.
Contributor
Author
Done :) |
bbovenzi
approved these changes
Sep 30, 2025
Contributor
Author
|
@bbovenzi looks like you've need to approve again after I updated from main. |
Contributor
Author
|
@bbovenzi Another query but do the maintainers merge the pr themselves or can we do it as well ? |
Member
Only Maintainers with write permissions to the project are able to merge PRs |
pierrejeambrun
approved these changes
Sep 30, 2025
Contributor
Author
Got it thanks for the clarification, the tests have passed now. |
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2025
* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>
Contributor
Backport successfully created: v3-1-test
|
jscheffl
pushed a commit
that referenced
this pull request
Sep 30, 2025
…#56258) * Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component. (cherry picked from commit 3f7991f) Co-authored-by: Vedant Mamgain <mamgainvedant@gmail.com>
dabla
pushed a commit
to dabla/airflow
that referenced
this pull request
Oct 12, 2025
* Replace defaultValue with value in TaskTrySelect Changed the Select component to use the controlled 'value' prop instead of 'defaultValue' for try number selection, ensuring the selected value updates correctly with state changes. * fix: Reorder props in TaskTrySelect for linting compliance Applied prop ordering fix as requested in code review. Props are now alphabetically ordered in the Select.Root component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the Select component to use the controlled 'value' prop instead of 'defaultValue'
for try number selection, ensuring the selected value updates correctly with state changes.
This ensures that the stale
<select>gets updated just like<option>closes: 55830
Test Plan
<select>isn't stale anymore.