Fix Python 3.12+ fork warning in async Task SDK connection tests#56019
Merged
kaxil merged 1 commit intoapache:mainfrom Sep 24, 2025
Merged
Fix Python 3.12+ fork warning in async Task SDK connection tests#56019kaxil merged 1 commit intoapache:mainfrom
kaxil merged 1 commit intoapache:mainfrom
Conversation
Resolves intermittent test failure where `asgiref.sync.sync_to_async` creates ThreadPoolExecutors that persist between tests, causing Python 3.12+ to warn about forking multi-threaded processes when supervisor.py calls `os.fork()`. Added targeted cleanup of asgiref executors after async tests to ensure clean thread environment for subsequent tests that use `fork()`. Example failure: https://github.com/apache/airflow/actions/runs/17957802850/job/51079451184#step:9:696
Member
Author
|
Failures are due to docker rate limit:
|
jedcunningham
approved these changes
Sep 24, 2025
amoghrajesh
approved these changes
Sep 24, 2025
Contributor
amoghrajesh
left a comment
There was a problem hiding this comment.
That's a strange one! Was it introduced "now" due to some dependency bump or it was just a matter of fact till we eventually hit it?
kaxil
added a commit
that referenced
this pull request
Sep 26, 2025
(cherry picked from commit 8e6f03e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We encountered an intermittent test failure on Python 3.12 only in the Task SDK: https://github.com/apache/airflow/actions/runs/17957802850/job/51079451184#step:9:696 and marked that test as
XFAIL: 6d2aac6Failed Test: `
Example failure: https://github.com/apache/airflow/actions/runs/17957802850/job/51079451184#step:9:696
Root Cause Analysis
The Threading Issue
Python 3.12 introduced a
DeprecationWarningwhenos.fork()is called in a multi-threaded process.Code Path Investigation
Through systematic analysis, we discovered:
asgiref.sync.sync_to_asynccreates persistentThreadPoolExecutorthreadstask-sdk/src/airflow/sdk/execution_time/context.py:217Testing Instructions for Reviewers:
Example run:
I do not want to admit how much time I & @jedcunningham spent on debugging this frustratingly :)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.