Fix default json encoder serialization in Task SDK logging#45962
Merged
feluelle merged 4 commits intoapache:mainfrom Jan 29, 2025
Merged
Fix default json encoder serialization in Task SDK logging#45962feluelle merged 4 commits intoapache:mainfrom
feluelle merged 4 commits intoapache:mainfrom
Conversation
ashb
reviewed
Jan 23, 2025
ashb
approved these changes
Jan 23, 2025
Member
ashb
left a comment
ashb
left a comment
There was a problem hiding this comment.
Maybe see if we can remove msgspec dep now? LGTM otherwise
amoghrajesh
approved these changes
Jan 23, 2025
Contributor
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
One qn, rest looks good
jcrist
reviewed
Jan 24, 2025
potiuk
reviewed
Jan 26, 2025
ashb
approved these changes
Jan 27, 2025
ianbuss
changed the title
Member
|
Merging as the failed mypy check is unrelated. |
got686-yandex
pushed a commit
to got686-yandex/airflow
that referenced
this pull request
Jan 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When presented with an non-stdlib object the current msgspec JSON encoder used by the Task SDK throws an ugly exception and causes the supervisor to crash. This can happen for example if presented with a Pydantic class such as is used between the supervisor and the API server.
This PR makes a very targeted change to provide the default encoding function to the msgspec encoder if it is supplied.
A test is added to ensure the JSON serialization works when a Pydantic class is supplied.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.