Skip to content

HOV-44 | Select component - MultiSelect#97

Merged
pruthvi2103 merged 28 commits intomainfrom
select-component
Sep 16, 2022
Merged

HOV-44 | Select component - MultiSelect#97
pruthvi2103 merged 28 commits intomainfrom
select-component

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

MultiSelect enhancement to Select component

Description

Added MultiSelect enhancement to Select component

Motivation and Context

Provides functionality to select multiple items

How Has This Been Tested?

local Build successful and manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@saurabhsutar192 saurabhsutar192 changed the title Select component Select component - MultiSelect Sep 13, 2022
@saurabhsutar192 saurabhsutar192 added this to the v0.1.9-alpha milestone Sep 13, 2022
@saurabhsutar192 saurabhsutar192 requested review from pruthvi2103 and removed request for Divyapoonthottam September 13, 2022 12:16
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 13, 2022

Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 267310b
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/63205326d378870009a37810
😎 Deploy Preview https://deploy-preview-97--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 13, 2022

Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit 3430754
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6324153c62fea60009f25567

Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment

Comment thread lib/src/components/Select/select.css.ts Outdated
@Raalzz Raalzz added the enhancement New feature or request label Sep 16, 2022
@Raalzz Raalzz linked an issue Sep 16, 2022 that may be closed by this pull request
@pruthvi2103 pruthvi2103 changed the title Select component - MultiSelect HOV-44 | Select component - MultiSelect Sep 16, 2022
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 49cfd3e into main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhancement | Combobox : Support MultiSelect

3 participants