Skip to content

HOV-3x | DateTimePicker Component#90

Merged
pruthvi2103 merged 8 commits intomainfrom
date-time-component
Oct 13, 2022
Merged

HOV-3x | DateTimePicker Component#90
pruthvi2103 merged 8 commits intomainfrom
date-time-component

Conversation

@Shadow-Flash
Copy link
Copy Markdown
Contributor

@Shadow-Flash Shadow-Flash commented Sep 3, 2022 •
edited
Loading

Description

  • Implemented a new date time picker component using the Input component.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Screenshot 2022-09-09 at 3 37 36 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@Shadow-Flash Shadow-Flash added documentation Improvements or additions to documentation New Component Addition of new Components Design Needed labels Sep 3, 2022
@Shadow-Flash Shadow-Flash self-assigned this Sep 3, 2022
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 3, 2022 •
edited
Loading

✅ Deploy Preview for hover-design ready!

Name Link
🔨 Latest commit 17ceec8
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6347dc54a620a4000826e0ac
😎 Deploy Preview https://deploy-preview-90--hover-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Shadow-Flash Shadow-Flash linked an issue Sep 3, 2022 that may be closed by this pull request
HOV-20 | DateTimePicker Component #49
Closed
3 tasks
@Raalzz
Copy link
Copy Markdown
Member

Raalzz commented Sep 16, 2022

@Shadow-Flash Figma Link: https://www.figma.com/file/IZHRiuhZEG4GCIMpBKA7ar/Hover?node-id=1894%3A1241

@Raalzz
Copy link
Copy Markdown
Member

Raalzz commented Sep 16, 2022

Converting this to a Draft PR, As its still in progress

@Raalzz Raalzz marked this pull request as draft September 16, 2022 05:18
@Shadow-Flash
[UPDATED] user style merges with current styling
bae52b3 
@pruthvi2103 will edit popup in version 2, it's okay to release this much now
@Shadow-Flash Shadow-Flash requested a review from Raalzz October 6, 2022 08:12
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Shadow-Flash Shadow-Flash marked this pull request as ready for review October 13, 2022 09:42
pruthvi2103
pruthvi2103 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit 5df4f5d into main Oct 13, 2022
@pruthvi2103 pruthvi2103 deleted the date-time-component branch October 13, 2022 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Raalzz Raalzz Awaiting requested review from Raalzz

1 more reviewer

@pruthvi2103 pruthvi2103 pruthvi2103 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Shadow-Flash Shadow-Flash

Labels

documentation Improvements or additions to documentation New Component Addition of new Components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

HOV-20 | DateTimePicker Component

3 participants

@Shadow-Flash @Raalzz @pruthvi2103