Skip to content

Native select component#88

Merged
pruthvi2103 merged 10 commits intomainfrom
nativeSelect-component
Sep 2, 2022
Merged

Native select component#88
pruthvi2103 merged 10 commits intomainfrom
nativeSelect-component

Conversation

@saurabhsutar192
Copy link
Copy Markdown
Contributor

Native Select

Description

Customized select for native select option

Motivation and Context

A good-looking native select

How Has This Been Tested?

local build successful and manual

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@netlify
Copy link
Copy Markdown

netlify bot commented Sep 2, 2022

Deploy Preview for hover-design canceled.

Name Link
🔨 Latest commit e354866
🔍 Latest deploy log https://app.netlify.com/sites/hover-design/deploys/6311e87cf41f77000806dfbc

@pruthvi2103 pruthvi2103 added the New Component Addition of new Components label Sep 2, 2022
@pruthvi2103 pruthvi2103 added this to the v0.1.8-alpha milestone Sep 2, 2022
@pruthvi2103
Copy link
Copy Markdown
Contributor

closes #38

@pruthvi2103 pruthvi2103 linked an issue Sep 2, 2022 that may be closed by this pull request
3 tasks
Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small change

Comment thread docs/docs/components/nativeSelect.mdx Outdated
];

<div className="App">
<NativeSelect roundness={"50px"} error="This is an error" options={options} />
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we change roundedness with borderRadius?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i mean everywhere in the component

Copy link
Copy Markdown
Contributor

@pruthvi2103 pruthvi2103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pruthvi2103 pruthvi2103 merged commit dbee35d into main Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Component Addition of new Components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HOV-30 | NativeSelect component

2 participants