Merged
Conversation
✅ Deploy Preview for hover-design canceled.
|
pruthvi2103
suggested changes
Sep 2, 2022
Contributor
pruthvi2103
left a comment
pruthvi2103
left a comment
There was a problem hiding this comment.
Some comments, also while testing i found following problems:
During tab navigation, pressing space does not open the select.
| SelectPropsType | ||
| > = ( | ||
| { | ||
| placeholder = "Pick one", |
Contributor
There was a problem hiding this comment.
Do not keep default placeholders, it results un-intentional behaviour keep it blank
| value, | ||
| height = "40px", | ||
| width = "100%", | ||
| roundness = "0", |
Contributor
There was a problem hiding this comment.
isnt borderRadius a better name?
| isMulti = false, | ||
| DropIcon, | ||
| error = false, | ||
| nothingFoundLabel = "Nothing Found!", |
Contributor
There was a problem hiding this comment.
again do not add default text here
Comment on lines
+53
to
+54
| onDropDownClose = () => {}, | ||
| onDropDownOpen = () => {}, |
Contributor
There was a problem hiding this comment.
nitpick: do not add default value here, if its not provided let it be undefined
| export * from "./components/Tab"; | ||
| export * from "./components/Avatar"; | ||
| export * from "./components/Table"; | ||
| export * from "./components/ComboBox"; |
Contributor
There was a problem hiding this comment.
we decided to change name to Select right?
Contributor
Author
There was a problem hiding this comment.
forgot to rename the folder
|
|
||
| // Reload only if ref or handler changes | ||
| }, [ref, handler]); | ||
| }, [ref, handler, isCallbackEnabled]); |
pruthvi2103
suggested changes
Sep 2, 2022
Comment on lines
+1
to
+41
| export const ArrowDown = () => { | ||
| return ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| width={18} | ||
| height={18} | ||
| viewBox="0 0 24 24" | ||
| strokeWidth={2} | ||
| stroke="currentColor" | ||
| fill="none" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| > | ||
| <path stroke="none" d="M0 0h24v24H0z" fill="none"></path> | ||
| <line x1={12} y1={5} x2={12} y2={19}></line> | ||
| <line x1={18} y1={13} x2={12} y2={19}></line> | ||
| <line x1={6} y1={13} x2={12} y2={19}></line> | ||
| </svg> | ||
| ); | ||
| }; | ||
|
|
||
| export const Clear = () => { | ||
| return ( | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| className="icon icon-tabler icon-tabler-circle-x" | ||
| width={18} | ||
| height={18} | ||
| viewBox="0 0 24 24" | ||
| strokeWidth="2" | ||
| stroke="currentColor" | ||
| fill="none" | ||
| strokeLinecap="round" | ||
| strokeLinejoin="round" | ||
| > | ||
| <path stroke="none" d="M0 0h24v24H0z" fill="none"></path> | ||
| <circle cx={12} cy={12} r={9}></circle> | ||
| <path d="M10 10l4 4m0 -4l-4 4"></path> | ||
| </svg> | ||
| ); | ||
| }; |
Contributor
There was a problem hiding this comment.
shift this to lib/src/components/_internal/Icons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Select Component
Description
Select component is a combobox that supports selecting or searching and selecting and many more things
Motivation and Context
A versatile select box that support many inbuilt functionalities
How Has This Been Tested?
Manual and Local Build successful
Screenshots (if appropriate):
Types of changes
Checklist: